Skip to content

Commit de87d09

Browse files
committed
address minor comments
1 parent 7a63d93 commit de87d09

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,7 @@ IsValidMatrixOpParams(VectorType dataTy, MemDescType mdescTy,
199199
if (llvm::any_of(llvm::zip_equal(dataShape, mdescShape),
200200
[](auto p) { return std::get<0>(p) > std::get<1>(p); }))
201201
return emitError() << "data shape must not exceed mem_desc shape.";
202-
} else if (dataShape.size() == 1) {
203-
202+
} else {
204203
SmallVector<int64_t> blockShape = mdescTy.getBlockShape();
205204
// if the subgroup_block_io attribute is set, mdescTy must have block
206205
// attribute
@@ -212,8 +211,6 @@ IsValidMatrixOpParams(VectorType dataTy, MemDescType mdescTy,
212211
if (subgroup_block_io && mdescTy.isColMajor())
213212
return emitError() << "mem_desc should be row major when "
214213
"subgroup_block_io is set.";
215-
} else if (dataShape.size() == 0) {
216-
return emitError() << "result shape must not be empty.";
217214
}
218215

219216
return success();

0 commit comments

Comments
 (0)