Remove the change to when we allow evaluation. Splitting into its own PR.

Author: ashgti

lldb/test/API/tools/lldb-dap/variables/TestDAP_variables.py

@@ -738,7 +738,7 @@ def test_indexedVariables_with_raw_child_for_synthetics(self):
         self.do_test_indexedVariables(enableSyntheticChildDebugging=True)
 
     @skipIfWindows
-    @skipIfAsan # FIXME this fails with a non-asan issue on green dragon.
+    @skipIfAsan  # FIXME this fails with a non-asan issue on green dragon.
     def test_registers(self):
         """
         Test that registers whose byte size is the size of a pointer on

lldb/tools/lldb-dap/Handler/EvaluateRequestHandler.cpp

@@ -205,10 +205,7 @@ void EvaluateRequestHandler::operator()(
     if (value.GetError().Success() && context == "repl")
       value = value.Persist();
 
-    // Only the repl should evaluate expressions, which can mutate application
-    // state. Other contexts are used for observing debuggee state only, not
-    // mutating state.
-    if (value.GetError().Fail() && context == "repl")
+    if (value.GetError().Fail() && context != "hover")
       value = frame.EvaluateExpression(expression.data());
 
     if (value.GetError().Fail()) {