Skip to content

Commit df5306b

Browse files
committed
[lldb][cmake] Error out when building debugserver with CMake 4
CMake 4 no longer sets the `CMAKE_OSX_SYSROOT` variable by default. If you've updated to CMake 4 on macOS (e.g. with brew) and try building LLDB with CMake/ninja, this will yield an error when building debugserver that clang is unable to run since it tries to compile files that don't exist. These files are supposed to be generated by the `mig` process. `mig` needs the `CMAKE_OSX_SYSROOT` variable in order to work and without it, it silently fails to generate the files that later on need to be compiled. This commit will fatal error out of config when building debugserver without having set CMAKE_OSX_SYSROOT.
1 parent 76d83e6 commit df5306b

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lldb/tools/debugserver/source/CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,10 @@ endif()
154154

155155
add_definitions(-DLLDB_USE_OS_LOG)
156156

157+
if(NOT CMAKE_OSX_SYSROOT)
158+
message(FATAL_ERROR "debugserver needs the macOS SDK root. Please pass in -DCMAKE_OSX_SYSROOT in your CMake invocation")
159+
endif()
160+
157161
if(${CMAKE_OSX_SYSROOT} MATCHES ".Internal.sdk$")
158162
message(STATUS "LLDB debugserver energy support is enabled")
159163
add_definitions(-DLLDB_ENERGY)

0 commit comments

Comments
 (0)