This test was incorrectly assuming that by the time connect to a

gdb-server was complete, lldb MUST have fetched the complete register
state for the stopped thread.  There's no reason why it has to do that
(especially since we get the PC from the stop message).  In a previous
patch, I made it not unnecessarily pull the full register contect, causing
this test to fail.
This commit changes the test to only require the 'g' packet AFTER we
had done 'read_register'.

Author: jimingham

lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py

@@ -132,12 +132,32 @@ def test_read_registers_using_g_packets(self):
         target = self.createTarget("a.yaml")
         process = self.connect(target)
 
-        self.assertEqual(1, self.server.responder.packetLog.count("g"))
-        self.server.responder.packetLog = []
+        # We want to make sure that the process is using the g packet, but it's
+        # not required the "connect" should read all registers.  However, it might
+        # have...  So we need to wait till we explicitly 'read_registers' to do
+        # test.
+        # Also, even with the use-g-packet-for-reading lldb will sometimes send p0
+        # early on to see if the packet is supported.  So we can't say that there
+        # will be NO p packets.
+        # But there certainly should be no p packets after the g packet.
+        
         self.read_registers(process)
-        # Reading registers should not cause any 'p' packets to be exchanged.
+        print(f"\nPACKET LOG:\n{self.server.responder.packetLog}\n")
+        g_pos = 0
+        try:
+            g_pos = self.server.responder.packetLog.index("g")
+        except err:
+            self.fail("'g' packet not found after fetching registers")
+
+        try:
+            second_g = self.server.responder.packetLog.index("g", g_pos)
+            self.fail("Found more than one 'g' packet")
+        except:
+            pass
+
+        # Make sure there aren't any `p` packets after the `g` packet:
         self.assertEqual(
-            0, len([p for p in self.server.responder.packetLog if p.startswith("p")])
+            0, len([p for p in self.server.responder.packetLog[g_pos:] if p.startswith("p")])
         )
 
     def test_read_registers_using_p_packets(self):