You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[libcxx] [test] Change an MSVC mode XFAIL into UNSUPPORTED
The underlying bug in vcruntime [1] has been fixed in the latest
version of MSVC (released two weeks ago); this will cause the
test which is currently marked XFAIL to start erroring, when it
starts passing unexpectedly.
This version of MSVC may soon start appearing in the Github Actions
runner images used for our CI.
We could try to detect the state of this bug, but in practice,
such detection code would essentially be a copy of this whole
test.
Therefore, just mark this test UNSUPPORTED for the MSVC mode builds.
If we at some point require new enough MSVC libraries, we could
remove the marking entirely.
[1] https://developercommunity.visualstudio.com/t/vcruntime-nothrow-array-operator-new-fal/10373274
Copy file name to clipboardExpand all lines: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new.size_nothrow.replace.indirect.pass.cpp
+5-1Lines changed: 5 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -21,7 +21,11 @@
21
21
// MSVC/vcruntime falls back from the nothrow array new to the nothrow
22
22
// scalar new, instead of falling back on the throwing array new.
0 commit comments