Address PR comments.

Author: tynasello

clang/lib/Sema/SemaDeclAttr.cpp

@@ -2194,15 +2194,15 @@ static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
     return;
   S.Diag(D->getLocation(), diag::warn_global_constructor)
       << D->getSourceRange();
-  D->addAttr(::new (S.Context) ConstructorAttr(S.Context, AL, E.get()));
+  D->addAttr(ConstructorAttr::Create(S.Context, E.get(), AL));
 }
 
 static void handleDestructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
   ExprResult E = sharedGetConstructorDestructorAttrExpr(S, AL);
   if (E.isInvalid())
     return;
   S.Diag(D->getLocation(), diag::warn_global_destructor) << D->getSourceRange();
-  D->addAttr(::new (S.Context) DestructorAttr(S.Context, AL, E.get()));
+  D->addAttr(DestructorAttr::Create(S.Context, E.get(), AL));
 }
 
 template <typename AttrTy>

clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

@@ -257,7 +257,7 @@ static void sharedInstantiateConstructorDestructorAttr(
       }
     }
   }
-  New->addAttr(new (C) Attr(C, *A, tempInstPriority));
+  New->addAttr(Attr::Create(C, tempInstPriority, *A));
 }
 
 static Expr *instantiateDependentFunctionAttrCondition(