Add test cases

Author: schittir

clang/include/clang/Basic/AttrDocs.td

@@ -501,8 +501,7 @@ may optionally be present on subsequent declarations.
 When compiling for a SYCL device target that does not support the generic
 address space, the function shall not specify a raw pointer or reference type
 as the return type or as a parameter type.
-See section 5.9, "Address-space deduction", of the SYCL 2020 specification.
-
+See section 5.10, "SYCL offline linking", of the SYCL 2020 specification.
 The following examples demonstrate the use of this attribute:
 
 .. code-block:: c++

clang/lib/Sema/SemaDecl.cpp

@@ -16301,6 +16301,13 @@ Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt *Body,
     }
   }
 
+  if (FD && !FD->isInvalidDecl() && FD->hasAttr<SYCLExternalAttr>()) {
+    SYCLExternalAttr *SEAttr = FD->getAttr<SYCLExternalAttr>();
+    if (FD->isDeletedAsWritten())
+      Diag(SEAttr->getLocation(),
+           diag::err_sycl_attribute_invalid_deleted_function);
+  }
+
   {
     // Do not call PopExpressionEvaluationContext() if it is a lambda because
     // one is already popped when finishing the lambda in BuildLambdaExpr().

clang/test/SemaSYCL/sycl-external-attr-appertainment.cpp

@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -std=c++17 -verify %s
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -std=c++20 -verify %s
+// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -std=c++23 -verify %s
+
+// expected-error@+1{{'clang::sycl_external' attribute only applies to functions}}
+[[clang::sycl_external]] int bad1;
+
+
+// expected-error@+2{{'clang::sycl_external' attribute only applies to functions}}
+struct s {
+[[clang::sycl_external]] int bad2;
+};
+
+// expected-error@+1{{'clang::sycl_external' attribute only applies to functions}}
+namespace [[clang::sycl_external]] bad3 {}
+
+// expected-error@+1{{'clang::sycl_external' attribute only applies to functions}}
+struct [[clang::sycl_external]]  bad4;
+
+// expected-error@+1{{'clang::sycl_external' attribute only applies to functions}}
+enum [[clang::sycl_external]] bad5 {};
+
+// expected-error@+1{{'clang::sycl_external' attribute only applies to functions}}
+int bad6(void (fp [[clang::sycl_external]])());
+
+// expected-error@+1{{'clang::sycl_external' attribute only applies to functions}}
+[[clang::sycl_external]];
+
+#if __cplusplus >= 202002L
+// expected-error@+2{{'clang::sycl_external' attribute only applies to functions}}
+template<typename>
+concept bad8 [[clang::sycl_external]] = true;
+#endif

clang/test/SemaSYCL/sycl-external-attr-grammar.cpp

@@ -1,9 +1,8 @@
 // RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify %s
 
-// expected-error@+1{{'clang::sycl_external' attribute takes no arguments}}
-[[clang::sycl_external(3)]] void bar() {}
 
-// FIXME: this case should be diagnosed too
+// FIXME: this case should be diagnosed.
+// This attribute takes no arguments.
 [[clang::sycl_external()]] void bad1();
 
 // expected-error@+1{{expected expression}}

clang/test/SemaSYCL/sycl-external-attr.cpp

@@ -66,8 +66,12 @@ class C {
 
 // expected-error@+2{{'sycl_external' cannot be applied to an explicitly deleted function}}
 class D {
-  [[clang::sycl_external]] void del() = delete;
+  [[clang::sycl_external]] void mdel() = delete;
 };
+
+// expected-error@+1{{'sycl_external' cannot be applied to an explicitly deleted function}}
+[[clang::sycl_external]] void del() = delete;
+
 struct NonCopyable {
   ~NonCopyable() = delete;
   [[clang::sycl_external]] NonCopyable(const NonCopyable&) = default;
@@ -98,8 +102,11 @@ class B {
 [[clang::sycl_external]] void fun3(int *);
 [[clang::sycl_external]] void fun4(int &);
 [[clang::sycl_external]] void fun5(int &&);
+template<typename T>
+[[clang::sycl_external]] void fun6(T) {}
+template void fun6(int *);
+template<> [[clang::sycl_external]] void fun6<long*>(long *) {}
 
 #if CPP20
 [[clang::sycl_external]] consteval int func();
 #endif
-