Address reviewer comments:

- Moved	DIL SharedPtr and UniquePtr tests to
 API/functionalities/data-formatter/data-formatter-stl/libcxx/dil_shared_ptr
and
 API/functionalities/data-formatter/data-formatter-stl/libcxx/dil_unique_ptr
- Moved	my new test to API/command/frame/var-dil/basics/SyntheticDereference.
- Changed 'smart_ptr' to 'wrap_ptr' in new test.
- Changed internal field name from '__ptr_' to 'ptr.
- Remove dead code from	test.
- Update pointer dereference test to test some expected	vs actual addresses,
  as suggested.

Author: cmtice

lldb/test/API/commands/frame/var-dil/basics/PointerDereference/TestFrameVarDILPointerDereference.py

@@ -32,3 +32,14 @@ def test_frame_var(self):
             error=True,
             substrs=["subscript of pointer to incomplete type 'void'"],
         )
+
+        # Verify some of the returned values.
+        pp_void0_2_got = self.expect_var_path("&pp_void0[2]", type="void **")
+        # Initialized in C++ code to point to the same value
+        pp_void0_2_exp = self.expect_var_path("pp_void0_2", type="void **")
+        self.assertEqual(pp_void0_2_got.GetValueAsAddress(),
+                         pp_void0_2_exp.GetValueAsAddress())
+        pp_int0_2stars_got = self.expect_var_path("&**pp_int0", type="int *")
+        pp_int0_2stars_exp = self.expect_var_path("pp_int0_2stars", type="int *")
+        self.assertEqual(pp_int0_2stars_got.GetValueAsAddress(),
+                         pp_int0_2stars_exp.GetValueAsAddress())

lldb/test/API/commands/frame/var-dil/basics/PointerDereference/main.cpp

@@ -26,6 +26,8 @@ int main(int argc, char **argv) {
   void **pp_void0 = &p_void;
   void **pp_void1 = pp_void0 + 1;
 
+  void **pp_void0_2 = &pp_void0[2];
+  int *pp_int0_2stars = &**pp_int0;
   std::nullptr_t std_nullptr_t = nullptr;
 
   return 0; // Set a breakpoint here

lldb/test/API/functionalities/data-formatter/fake-smart-ptr/Makefile renamed to lldb/test/API/commands/frame/var-dil/basics/SyntheticDereference/Makefile

@@ -1,5 +1,5 @@
 """
-Test code that should work on smart pointers, but make it impl independent.
+Test code for dereferencing synthetic wrapped pointers.
 """
 
 import lldb
@@ -8,7 +8,7 @@
 from lldbsuite.test import lldbutil
 
 
-class FakeSmartPtrDataFormatterTestCase(TestBase):
+class DILSyntheticDereferenceTestCase(TestBase):
     # If your test case doesn't stress debug info, then
     # set this to true.  That way it won't be run once for
     # each debug info format.
@@ -21,14 +21,14 @@ def test_frame_var(self):
         )
 
         self.runCmd("settings set target.experimental.use-DIL true")
-        self.runCmd("script from smartPtrSynthProvider import *")
-        self.runCmd("type synth add -l smartPtrSynthProvider smart_ptr")
+        self.runCmd("script from wrapPtrSynthProvider import *")
+        self.runCmd("type synth add -l wrapPtrSynthProvider wrap_ptr")
 
         self.expect_var_path("ptr_node->value", value="1")
         self.expect_var_path("ptr_node->next->value", value="2")
         self.expect_var_path("(*ptr_node).value", value="1")
         self.expect_var_path("(*(*ptr_node).next).value", value="2")
 
-        self.expect_var_path("ptr_node.__ptr_", type="NodeS *")
-        self.expect_var_path("ptr_node.__ptr_->value", value="1")
-        self.expect_var_path("ptr_node.__ptr_->next.__ptr_->value", value="2")
+        self.expect_var_path("ptr_node.ptr", type="NodeS *")
+        self.expect_var_path("ptr_node.ptr->value", value="1")
+        self.expect_var_path("ptr_node.ptr->next.ptr->value", value="2")

lldb/test/API/functionalities/data-formatter/fake-smart-ptr/TestFakeSmartPtrs.py renamed to lldb/test/API/commands/frame/var-dil/basics/SyntheticDereference/TestFrameVarDILSyntheticDereference.py

@@ -0,0 +1,26 @@
+#include <memory>
+
+struct NodeS;
+
+// Class to wrap pointers.
+class wrap_ptr {
+public:
+  NodeS *ptr;
+
+  wrap_ptr(NodeS *n_ptr) : ptr(n_ptr) {}
+};
+
+struct NodeS {
+  wrap_ptr next;
+  int value;
+
+  NodeS(NodeS *n_ptr, int val) : next(wrap_ptr(n_ptr)), value(val) {}
+};
+
+int main(int argc, char **argv) {
+
+  // Make a short linked list of fake smart pointers.
+  auto ptr_node = wrap_ptr(new NodeS(new NodeS(nullptr, 2), 1));
+
+  return 0; // Set a breakpoint here
+}

lldb/test/API/commands/frame/var-dil/basics/SyntheticDereference/main.cpp

@@ -1,7 +1,7 @@
 import lldb
 
 
-class smartPtrSynthProvider:
+class wrapPtrSynthProvider:
     def __init__(self, valobj, dict):
         self.valobj = valobj
 
@@ -10,19 +10,16 @@ def num_children(self):
 
     def get_child_at_index(self, index):
         if index == 0:
-            return self.valobj.GetChildMemberWithName("__ptr_")
+            return self.valobj.GetChildMemberWithName("ptr")
         if index == 1:
-            internal_child = self.valobj.GetChildMemberWithName("__ptr_")
+            internal_child = self.valobj.GetChildMemberWithName("ptr")
             if not internal_child:
                 return None
-            value_type = internal_child.GetType().GetPointerType()
-            cast_ptr_sp = internal_child.Cast(value_type)
-            value = internal_child.Dereference()
-            return value
+            return internal_child.Dereference()
         return None
 
     def get_child_index(self, name):
-        if name == "__ptr_":
+        if name == "ptr":
             return 0
         if name == "$$dereference$$":
             return 1