Skip to content

Commit e42f202

Browse files
committed
fixup! don't error on incompatible flag
1 parent f912b46 commit e42f202

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

llvm/test/tools/llvm-dwarfdump/X86/filter-child-tag.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,10 @@
5454
# FOO_MEM_WITH_PARENT-NOT: DW_TAG_structure_type
5555
# FOO_MEM_WITH_PARENT-NOT: DW_TAG_member
5656

57-
# RUN: not llvm-dwarfdump %t.o --name=Foo -t DW_TAG_member 2>&1 | FileCheck %s --check-prefix=ERROR_NO_SHOW_CHILDREN
57+
## Not specifying --show-children ignores the --filter-child-tag option.
58+
# RUN: llvm-dwarfdump %t.o --name=Foo -t DW_TAG_member 2>&1 | FileCheck %s --check-prefix=NO_SHOW_CHILDREN
5859

59-
# ERROR_NO_SHOW_CHILDREN: incompatible arguments: --filter-child-tag requires --show-children
60+
# NO_SHOW_CHILDREN: DW_TAG_structure_type
6061

6162
--- !ELF
6263
FileHeader:

llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -917,12 +917,6 @@ int main(int argc, char **argv) {
917917
Find.empty() && !FindAllApple)
918918
ShowChildren = true;
919919

920-
if (!ShowChildren && !FilterChildTag.empty()) {
921-
WithColor::error() << "incompatible arguments: --filter-child-tag requires "
922-
"--show-children";
923-
return 1;
924-
}
925-
926920
// Defaults to a.out if no filenames specified.
927921
if (InputFilenames.empty())
928922
InputFilenames.push_back("a.out");

0 commit comments

Comments
 (0)