Skip to content

Commit e545559

Browse files
committed
fixup! AMDGPU: Fix runtime unrolling when cascaded GEPs present
1 parent 2697574 commit e545559

File tree

1 file changed

+41
-21
lines changed

1 file changed

+41
-21
lines changed

llvm/test/Transforms/LoopUnroll/AMDGPU/unroll-runtime.ll

Lines changed: 41 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
; RUN: opt -mtriple=amdgcn-unknown-amdhsa -passes=loop-unroll -S %s | FileCheck %s
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
2+
; RUN: opt -mtriple=amdgcn-amd-amdhsa -passes=loop-unroll -S %s | FileCheck %s
23

34
%struct.wombat = type { %struct.zot, i32, [16 x i32], [16 x i32], i32, i32, [16 x i32], i32 }
45
%struct.zot = type { i32, i32, [1024 x i32] }
@@ -7,27 +8,46 @@
78

89
; Ensure that a cascaded GEP for local address space does not inhibit unrolling
910
;
10-
; CHECK-LABEL: @unroll_when_cascaded_gep
11-
; CHECK: bb:
12-
; CHECK: br {{.*}}, label %bb2.unr-lcssa, label %bb.new
13-
; CHECK: bb.new:
14-
; CHECK: %unroll_iter =
15-
; CHECK: br label %bb1
16-
; CHECK: bb1:
17-
; CHECK: br {{.*}}, label %bb2.unr-lcssa.loopexit, label %bb1
18-
; CHECK: bb2.unr-lcssa.loopexit:
19-
; CHECK: br label %bb2.unr-lcssa
20-
; CHECK: bb2.unr-lcssa:
21-
; CHECK: br {{.*}}, label %bb1.epil.preheader, label %bb2
22-
; CHECK: bb1.epil.preheader:
23-
; CHECK: br label %bb1.epil
24-
; CHECK: bb1.epil:
25-
; CHECK: br {{.*}}, label %bb1.epil, label %bb2.epilog-lcssa
26-
; CHECK: bb2.epilog-lcssa:
27-
; CHECK: br label %bb2
28-
; CHECK: bb2:
29-
; CHECK: ret void
3011
define amdgpu_kernel void @unroll_when_cascaded_gep(i32 %arg) {
12+
; CHECK-LABEL: @unroll_when_cascaded_gep(
13+
; CHECK-NEXT: bb:
14+
; CHECK-NEXT: [[TMP0:%.*]] = add i32 [[ARG:%.*]], 1
15+
; CHECK-NEXT: [[XTRAITER:%.*]] = and i32 [[TMP0]], 7
16+
; CHECK-NEXT: [[TMP1:%.*]] = icmp ult i32 [[ARG]], 7
17+
; CHECK-NEXT: br i1 [[TMP1]], label [[BB2_UNR_LCSSA:%.*]], label [[BB_NEW:%.*]]
18+
; CHECK: bb.new:
19+
; CHECK-NEXT: [[UNROLL_ITER:%.*]] = sub i32 [[TMP0]], [[XTRAITER]]
20+
; CHECK-NEXT: br label [[BB1:%.*]]
21+
; CHECK: bb1:
22+
; CHECK-NEXT: [[PHI:%.*]] = phi i32 [ 0, [[BB_NEW]] ], [ [[ADD_7:%.*]], [[BB1]] ]
23+
; CHECK-NEXT: [[NITER:%.*]] = phi i32 [ 0, [[BB_NEW]] ], [ [[NITER_NEXT_7:%.*]], [[BB1]] ]
24+
; CHECK-NEXT: [[ADD_7]] = add i32 [[PHI]], 8
25+
; CHECK-NEXT: [[NITER_NEXT_7]] = add i32 [[NITER]], 8
26+
; CHECK-NEXT: [[NITER_NCMP_7:%.*]] = icmp eq i32 [[NITER_NEXT_7]], [[UNROLL_ITER]]
27+
; CHECK-NEXT: br i1 [[NITER_NCMP_7]], label [[BB2_UNR_LCSSA_LOOPEXIT:%.*]], label [[BB1]]
28+
; CHECK: bb2.unr-lcssa.loopexit:
29+
; CHECK-NEXT: [[PHI_UNR_PH:%.*]] = phi i32 [ [[ADD_7]], [[BB1]] ]
30+
; CHECK-NEXT: br label [[BB2_UNR_LCSSA]]
31+
; CHECK: bb2.unr-lcssa:
32+
; CHECK-NEXT: [[PHI_UNR:%.*]] = phi i32 [ 0, [[BB:%.*]] ], [ [[PHI_UNR_PH]], [[BB2_UNR_LCSSA_LOOPEXIT]] ]
33+
; CHECK-NEXT: [[LCMP_MOD:%.*]] = icmp ne i32 [[XTRAITER]], 0
34+
; CHECK-NEXT: br i1 [[LCMP_MOD]], label [[BB1_EPIL_PREHEADER:%.*]], label [[BB2:%.*]]
35+
; CHECK: bb1.epil.preheader:
36+
; CHECK-NEXT: br label [[BB1_EPIL:%.*]]
37+
; CHECK: bb1.epil:
38+
; CHECK-NEXT: [[PHI_EPIL:%.*]] = phi i32 [ [[PHI_UNR]], [[BB1_EPIL_PREHEADER]] ], [ [[ADD_EPIL:%.*]], [[BB1_EPIL]] ]
39+
; CHECK-NEXT: [[EPIL_ITER:%.*]] = phi i32 [ 0, [[BB1_EPIL_PREHEADER]] ], [ [[EPIL_ITER_NEXT:%.*]], [[BB1_EPIL]] ]
40+
; CHECK-NEXT: [[GETELEMENTPTR_EPIL:%.*]] = getelementptr [1024 x i32], ptr addrspace(3) getelementptr inbounds nuw (i8, ptr addrspace(3) @global, i32 8), i32 0, i32 0
41+
; CHECK-NEXT: [[ADD_EPIL]] = add i32 [[PHI_EPIL]], 1
42+
; CHECK-NEXT: [[ICMP_EPIL:%.*]] = icmp eq i32 [[PHI_EPIL]], [[ARG]]
43+
; CHECK-NEXT: [[EPIL_ITER_NEXT]] = add i32 [[EPIL_ITER]], 1
44+
; CHECK-NEXT: [[EPIL_ITER_CMP:%.*]] = icmp ne i32 [[EPIL_ITER_NEXT]], [[XTRAITER]]
45+
; CHECK-NEXT: br i1 [[EPIL_ITER_CMP]], label [[BB1_EPIL]], label [[BB2_EPILOG_LCSSA:%.*]], !llvm.loop [[LOOP0:![0-9]+]]
46+
; CHECK: bb2.epilog-lcssa:
47+
; CHECK-NEXT: br label [[BB2]]
48+
; CHECK: bb2:
49+
; CHECK-NEXT: ret void
50+
;
3151
bb:
3252
br label %bb1
3353

0 commit comments

Comments
 (0)