Skip to content

Commit e5b6c36

Browse files
committed
Address review comments
1 parent 733a3f2 commit e5b6c36

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

llvm/utils/llvm-original-di-preservation.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -478,14 +478,14 @@ def get_json_chunk(file, start, size):
478478
# Parse the program arguments.
479479
def parse_program_args(parser):
480480
parser.add_argument("file_name", type=str, help="json file to process")
481-
parser.add_argument("--compress", action="store_true", help="create reduced report")
481+
parser.add_argument("--reduce", action="store_true", help="create reduced report")
482482

483483
report_type_group = parser.add_mutually_exclusive_group(required=True)
484484
report_type_group.add_argument(
485-
"--report-file", type=str, help="output HTML file for the generated report"
485+
"--report-html-file", type=str, help="output HTML file for the generated report"
486486
)
487487
report_type_group.add_argument(
488-
"--error-test",
488+
"--acceptance-test",
489489
action="store_true",
490490
help="if set, produce terminal-friendly output and return 0 iff the input file is empty or does not exist",
491491
)
@@ -497,7 +497,7 @@ def Main():
497497
parser = argparse.ArgumentParser()
498498
opts = parse_program_args(parser)
499499

500-
if opts.report_file is not None and not opts.report_file.endswith(".html"):
500+
if opts.report_html_file is not None and not opts.report_html_file.endswith(".html"):
501501
print("error: The output file must be '.html'.")
502502
sys.exit(1)
503503

@@ -654,15 +654,15 @@ def Main():
654654
if di_var_bugs:
655655
di_variable_bugs[bugs_file][bugs_pass] = di_var_bugs
656656

657-
if opts.report_file is not None:
657+
if opts.report_html_file is not None:
658658
generate_html_report(
659659
di_location_bugs,
660660
di_subprogram_bugs,
661661
di_variable_bugs,
662662
di_location_bugs_summary,
663663
di_sp_bugs_summary,
664664
di_var_bugs_summary,
665-
opts.report_file,
665+
opts.report_html_file,
666666
)
667667
else:
668668
# Pretty(ish) print the detected bugs, but check if any exist first so that we don't print an empty dict.

0 commit comments

Comments
 (0)