[lldb] add review changes

Author: da-viper

lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

@@ -1700,9 +1700,11 @@ static void LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
           },
           "MSVC STL/libstdc++ std::wstring summary provider"));
 
+  // NOTE: it is loaded as a common formatter because the libc++ version is not
+  // in the `__1` namespace, hence we need to dispatch based on the class layout.
   AddCXXSynthetic(cpp_category_sp,
                   GenericInitializerListSyntheticFrontEndCreator,
-                  "libc++/libstdc++ std::initializer_list synthetic children",
+                  "std::initializer_list synthetic children",
                   "^std::initializer_list<.+>$", stl_synth_flags, true);
 
   stl_summary_flags.SetDontShowChildren(false);

lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/initializer_list/TestDataFormatterStdInitializerList.py

@@ -28,10 +28,12 @@ def do_test(self):
             substrs=["stopped", "stop reason = breakpoint"],
         )
 
-        self.expect("frame variable ili", substrs=["[1] = 2", "[4] = 5"])
+        self.expect(
+            "frame variable ili", substrs=["ili = size=5", "[1] = 2", "[4] = 5"]
+        )
         self.expect(
             "frame variable ils",
-            substrs=['[4] = "surprise it is a long string!! yay!!"'],
+            substrs=["ils = size=5","[0] = 1", '[4] = "surprise it is a long string!! yay!!"'],
         )
 
     @add_test_categories(["libc++"])