[Sema] Diagnose use of if/else-if condition variable inside else-if/else branch(s)

Author: arrowten

clang/include/clang/Basic/DiagnosticSemaKinds.td

@@ -13594,6 +13594,9 @@ def warn_acc_var_referenced_lacks_op
               "reference has no effect">,
       InGroup<DiagGroup<"openacc-var-lacks-operation">>,
       DefaultError;
+def warn_out_of_scope_var_usage
+    : Warning<"variable %0 declared in 'if' block is either false or null">,
+      InGroup<DiagGroup<"conditional-scope">>;
 
 // AMDGCN builtins diagnostics
 def err_amdgcn_load_lds_size_invalid_value : Error<"invalid size value">;

clang/lib/Sema/SemaStmt.cpp

@@ -971,6 +971,35 @@ StmtResult Sema::ActOnIfStmt(SourceLocation IfLoc,
   if (!ConstevalOrNegatedConsteval && !elseStmt)
     DiagnoseEmptyStmtBody(RParenLoc, thenStmt, diag::warn_empty_if_body);
 
+  // Checks for if condition variable usage in else scope
+  if (elseStmt) {
+    if (auto* CondVar = dyn_cast_or_null<VarDecl>(Cond.get().first)) {
+      bool usedInElse = false;
+      std::function<bool(Stmt*)> checkForUsage = [&](Stmt *S) -> bool {
+	if (!S) return false;
+	if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(S)) {
+	  if (DRE->getDecl() == CondVar) {
+	    return true;
+	  }
+	}
+
+	for (Stmt *Child: S->children()) {
+	  if (checkForUsage(Child)) {
+	    return true;
+	  }
+	}
+
+	return false;
+      };
+      usedInElse = checkForUsage(elseStmt);
+
+      if (usedInElse) {
+	Diag(elseStmt->getBeginLoc(), diag::warn_out_of_scope_var_usage)
+	  << CondVar->getName();
+      }
+    }
+  }
+
   if (ConstevalOrNegatedConsteval ||
       StatementKind == IfStatementKind::Constexpr) {
     auto DiagnoseLikelihood = [&](const Stmt *S) {

clang/test/Sema/warn-conditional-scope.cpp

@@ -0,0 +1,74 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -Wconditional-scope -DTEST_1 %s
+// RUN: %clang_cc1 -fsyntax-only -verify -Wconditional-scope -DTEST_2 %s
+// RUN: %clang_cc1 -fsyntax-only -verify -Wconditional-scope -DTEST_3 %s
+
+int *get_something();
+int *get_something_else();
+int *get_something_else_again();
+int *get_something_else_again_now();
+
+#ifdef TEST_1
+
+int test() {
+  if (int *ptr = get_something()) {
+    return ptr[0] * ptr[0];
+  }
+  // expected-warning@+1{{variable ptr declared in 'if' block is either false or null}}
+  else if (int *ptr2 = get_something_else()) {
+    return ptr[0] * ptr2[0];
+  }
+  // expected-warning@+1{{variable ptr2 declared in 'if' block is either false or null}}
+  else if (int* ptr3 = get_something_else_again()) {
+    return ptr[0] * ptr2[0] * ptr3[0];	
+  }
+  // expected-warning@+1{{variable ptr3 declared in 'if' block is either false or null}}
+  else if (int *ptr4 = get_something_else_again_now()) {
+    return ptr[0] * ptr2[0] * ptr3[0] * ptr4[0];
+  }
+  else {
+    return -1;
+  }
+}
+
+#endif
+
+#ifdef TEST_2
+
+int test() {
+  if (int *ptr = get_something()) {
+    return ptr[0] * ptr[0];
+  }
+  // expected-warning@+1{{variable ptr declared in 'if' block is either false or null}}
+  else if (int *ptr2 = get_something_else()) {
+    return ptr2[0] * ptr2[0];
+  }
+  // expected-warning@+1{{variable ptr2 declared in 'if' block is either false or null}}
+  else if (int* ptr3 = get_something_else_again()) {
+    return ptr[0] * ptr2[0] * ptr3[0];
+  }
+  else {
+    return -1;
+  }
+}
+
+#endif
+
+#ifdef TEST_3
+
+int test() {
+  if (int *ptr = get_something()) {
+    return ptr[0] * ptr[0];
+  }
+  else if (int *ptr2 = get_something_else()) {
+    return ptr2[0] * ptr2[0];
+  }
+  // expected-warning@+1{{variable ptr2 declared in 'if' block is either false or null}}
+  else if (int* ptr3 = get_something_else_again()) {
+    return ptr2[0] * ptr2[0] * ptr3[0];
+  }
+  else {
+    return -1;
+  }
+}
+
+#endif