Skip to content

Commit e69dbad

Browse files
committed
change name to use not KHR version
1 parent 746d510 commit e69dbad

File tree

3 files changed

+13
-14
lines changed

3 files changed

+13
-14
lines changed

llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -631,10 +631,9 @@ void RequirementHandler::initAvailableCapabilities(const SPIRVSubtarget &ST) {
631631
Capability::Int16});
632632

633633
if (ST.isAtLeastSPIRVVer(VersionTuple(1, 6)))
634-
addAvailableCaps({Capability::DotProductKHR,
635-
Capability::DotProductInputAllKHR,
636-
Capability::DotProductInput4x8BitKHR,
637-
Capability::DotProductInput4x8BitPackedKHR});
634+
addAvailableCaps({Capability::DotProduct, Capability::DotProductInputAll,
635+
Capability::DotProductInput4x8Bit,
636+
Capability::DotProductInput4x8BitPacked});
638637

639638
// Add capabilities enabled by extensions.
640639
for (auto Extension : ST.getAllAvailableExtensions()) {
@@ -1012,7 +1011,7 @@ static void AddDotProductRequirements(const MachineInstr &MI,
10121011
const SPIRVSubtarget &ST) {
10131012
if (ST.canUseExtension(SPIRV::Extension::SPV_KHR_integer_dot_product))
10141013
Reqs.addExtension(SPIRV::Extension::SPV_KHR_integer_dot_product);
1015-
Reqs.addCapability(SPIRV::Capability::DotProductKHR);
1014+
Reqs.addCapability(SPIRV::Capability::DotProduct);
10161015

10171016
const MachineRegisterInfo &MRI = MI.getMF()->getRegInfo();
10181017
const MachineInstr *InstrPtr = &MI;
@@ -1022,13 +1021,13 @@ static void AddDotProductRequirements(const MachineInstr &MI,
10221021
SPIRVType *TypeDef = MRI.getVRegDef(TypeReg);
10231022
if (TypeDef->getOpcode() == SPIRV::OpTypeInt) {
10241023
assert(TypeDef->getOperand(1).getImm() == 32);
1025-
Reqs.addCapability(SPIRV::Capability::DotProductInput4x8BitPackedKHR);
1024+
Reqs.addCapability(SPIRV::Capability::DotProductInput4x8BitPacked);
10261025
} else if (TypeDef->getOpcode() == SPIRV::OpTypeVector) {
10271026
SPIRVType *ScalarTypeDef = MRI.getVRegDef(TypeDef->getOperand(1).getReg());
10281027
assert(ScalarTypeDef->getOpcode() == SPIRV::OpTypeInt);
10291028
auto Capability = ScalarTypeDef->getOperand(1).getImm() == 8
1030-
? SPIRV::Capability::DotProductInput4x8BitKHR
1031-
: SPIRV::Capability::DotProductInputAllKHR;
1029+
? SPIRV::Capability::DotProductInput4x8Bit
1030+
: SPIRV::Capability::DotProductInputAll;
10321031
Reqs.addCapability(Capability);
10331032
}
10341033
}

llvm/lib/Target/SPIRV/SPIRVSymbolicOperands.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -467,10 +467,10 @@ defm ExpectAssumeKHR : CapabilityOperand<5629, 0, 0, [SPV_KHR_expect_assume], []
467467
defm FunctionPointersINTEL : CapabilityOperand<5603, 0, 0, [SPV_INTEL_function_pointers], []>;
468468
defm IndirectReferencesINTEL : CapabilityOperand<5604, 0, 0, [SPV_INTEL_function_pointers], []>;
469469
defm AsmINTEL : CapabilityOperand<5606, 0, 0, [SPV_INTEL_inline_assembly], []>;
470-
defm DotProductInputAllKHR : CapabilityOperand<6016, 0, 0, [SPV_KHR_integer_dot_product], []>;
471-
defm DotProductInput4x8BitKHR : CapabilityOperand<6017, 0, 0, [SPV_KHR_integer_dot_product], [Int8]>;
472-
defm DotProductInput4x8BitPackedKHR : CapabilityOperand<6018, 0, 0, [SPV_KHR_integer_dot_product], []>;
473-
defm DotProductKHR : CapabilityOperand<6019, 0, 0, [SPV_KHR_integer_dot_product], []>;
470+
defm DotProductInputAll : CapabilityOperand<6016, 0, 0, [SPV_KHR_integer_dot_product], []>;
471+
defm DotProductInput4x8Bit : CapabilityOperand<6017, 0, 0, [SPV_KHR_integer_dot_product], [Int8]>;
472+
defm DotProductInput4x8BitPacked : CapabilityOperand<6018, 0, 0, [SPV_KHR_integer_dot_product], []>;
473+
defm DotProduct : CapabilityOperand<6019, 0, 0, [SPV_KHR_integer_dot_product], []>;
474474
defm GroupNonUniformRotateKHR : CapabilityOperand<6026, 0, 0, [SPV_KHR_subgroup_rotate], [GroupNonUniform]>;
475475
defm AtomicFloat32AddEXT : CapabilityOperand<6033, 0, 0, [SPV_EXT_shader_atomic_float_add], []>;
476476
defm AtomicFloat64AddEXT : CapabilityOperand<6034, 0, 0, [SPV_EXT_shader_atomic_float_add], []>;

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/dot4add_i8packed.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
; RUN: %if spirv-tools %{ llc -verify-machineinstrs -O0 -mtriple=spirv1.6-unknown-unknown %s -o - -filetype=obj | spirv-val %}
66
; RUN: %if spirv-tools %{ llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown -spirv-ext=+SPV_KHR_integer_dot_product %s -o - -filetype=obj | spirv-val %}
77

8-
; CHECK-DOT: OpCapability DotProductKHR
9-
; CHECK-DOT: OpCapability DotProductInput4x8BitPackedKHR
8+
; CHECK-DOT: OpCapability DotProduct
9+
; CHECK-DOT: OpCapability DotProductInput4x8BitPacked
1010
; CHECK-EXT: OpExtension "SPV_KHR_integer_dot_product"
1111

1212
; CHECK: %[[#int_32:]] = OpTypeInt 32 0

0 commit comments

Comments
 (0)