[clang][ThreadSafety] Handle mutex scope

Before emitting warning about locks being held at the end of function
scope check if the underlying mutex is function scoped or not.

Author: Prabhuk

clang/lib/Analysis/ThreadSafety.cpp

@@ -2443,6 +2443,22 @@ void ThreadSafetyAnalyzer::intersectAndWarn(FactSet &EntrySet,
       if (join(FactMan[*EntryIt], ExitFact, JoinLoc, EntryLEK))
         *EntryIt = Fact;
     } else if (!ExitFact.managed() || EntryLEK == LEK_LockedAtEndOfFunction) {
+      if (EntryLEK == LEK_LockedAtEndOfFunction) {
+        const til::SExpr *Sexp = ExitFact.sexpr();
+        const VarDecl *Var = nullptr;
+
+        if (const auto *Proj = dyn_cast<til::Project>(Sexp)) {
+          if (const auto *Base = dyn_cast<til::LiteralPtr>(Proj->record()))
+            Var = dyn_cast_or_null<VarDecl>(Base->clangDecl());
+        } else if (const auto *LP = dyn_cast<til::LiteralPtr>(Sexp)) {
+          Var = dyn_cast_or_null<VarDecl>(LP->clangDecl());
+        }
+
+        if (Var && Var->getStorageDuration() == SD_Automatic &&
+            Var->getDeclContext() == CurrentFunction) {
+          continue;
+        }
+      }
       ExitFact.handleRemovalFromIntersection(ExitSet, FactMan, JoinLoc,
                                              EntryLEK, Handler);
     }

libcxx/test/extensions/clang/thread/thread.mutex/lock.verify.cpp

@@ -45,3 +45,9 @@ void f3() {
      expected-warning {{mutex 'm2' is still held at the end of function}} \
      expected-warning {{mutex 'm3' is still held at the end of function}}
 #endif
+
+void f4() {
+  std::mutex local_m0;
+  std::mutex local_m1;
+  std::lock(local_m0, local_m1);
+}