added casting to avoid integer promotion

Sriya Pratipati · Sriya Pratipati · commit e7669d3ae366 · 2025-06-16T23:27:37.000Z
diff --git a/libc/src/__support/wchar/character_converter.cpp b/libc/src/__support/wchar/character_converter.cpp
@@ -44,7 +44,7 @@ int CharacterConverter::push(char8_t utf8_byte) {
       /* Since the format is 110xxxxx, 1110xxxx, and 11110xxx for 2, 3, and 4,
       we will make the base mask with 7 ones and right shift it as necessary. */
       constexpr size_t SIGNIFICANT_BITS = 7;
-      uint8_t base_mask = mask_trailing_ones<uint8_t, SIGNIFICANT_BITS>();
+      char8_t base_mask = static_cast<char8_t>(mask_trailing_ones<uint8_t, SIGNIFICANT_BITS>());
       state->total_bytes = num_ones;
       utf8_byte &= (base_mask >> num_ones);
     }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ int CharacterConverter::push(char8_t utf8_byte) {`
`44`	`44`	`/* Since the format is 110xxxxx, 1110xxxx, and 11110xxx for 2, 3, and 4,`
`45`	`45`	`we will make the base mask with 7 ones and right shift it as necessary. */`
`46`	`46`	`constexpr size_t SIGNIFICANT_BITS = 7;`
`47`		`- uint8_t base_mask = mask_trailing_ones<uint8_t, SIGNIFICANT_BITS>();`
	`47`	`+ char8_t base_mask = static_cast<char8_t>(mask_trailing_ones<uint8_t, SIGNIFICANT_BITS>());`
`48`	`48`	`state->total_bytes = num_ones;`
`49`	`49`	`utf8_byte &= (base_mask >> num_ones);`
`50`	`50`	`}`