Skip to content

Commit e7bc902

Browse files
committed
Clean up code when copying personal tool, explain the raii comment better.
1 parent f6d8d81 commit e7bc902

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

lldb/test/API/tools/lldb-dap/progress/Progress_emitter.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def register_lldb_command(cls, debugger, module_name):
2929
@classmethod
3030
def create_options(cls):
3131
usage = "usage: %prog [options]"
32-
description = "Jacob Lalonde's sbprogress testing tool"
32+
description = "SBProgress testing tool"
3333
# Opt parse is deprecated, but leaving this the way it is because it allows help formating
3434
# Additionally all our commands use optparse right now, ideally we migrate them all in one go.
3535
parser = optparse.OptionParser(
@@ -70,7 +70,6 @@ def __call__(self, debugger, command, exe_ctx, result):
7070
total = cmd_options.total
7171
progress = lldb.SBProgress("Progress tester", "Detail", total, debugger)
7272

73-
# This actually should start at 1 but it's 6:30 on a Friday...
7473
for i in range(1, total):
7574
progress.Increment(1, f"Step {i}")
7675
time.sleep(cmd_options.seconds)

lldb/test/API/tools/lldb-dap/progress/TestDAP_Progress.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def test_output(self):
3232

3333
self.dap_server.wait_for_event("progressEnd", 15)
3434
# Expect at least a start, an update, and end event
35-
# However because the progress is an RAII object and we can't guaruntee
35+
# However because the underlying Progress instance is an RAII object and we can't guaruntee
3636
# it's deterministic destruction in the python API, we verify just start and update
3737
# otherwise this test could be flakey.
3838
self.assertTrue(len(self.dap_server.progress_events) > 0)

0 commit comments

Comments
 (0)