[llvm] Validate Parent object before dereference (#157460)

apach301 · web-flow · commit e8028b2ecb5b · 2025-09-17T07:54:41.000+01:00
Fixes #157449
diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp
@@ -473,9 +473,7 @@ Archive::Child::Child(const Archive *Parent, const char *Start, Error *Err)
   }
 
   Header = Parent->createArchiveMemberHeader(
-      Start,
-      Parent ? Parent->getData().size() - (Start - Parent->getData().data())
-             : 0,
+      Start, Parent->getData().size() - (Start - Parent->getData().data()),
       Err);
 
   // If we are pointed to real data, Start is not a nullptr, then there must be

Original file line number	Diff line number	Diff line change
`@@ -473,9 +473,7 @@ Archive::Child::Child(const Archive Parent, const char Start, Error *Err)`
`473`	`473`	`}`
`474`	`474`
`475`	`475`	`Header = Parent->createArchiveMemberHeader(`
`476`		`- Start,`
`477`		`- Parent ? Parent->getData().size() - (Start - Parent->getData().data())`
`478`		`- : 0,`
	`476`	`+ Start, Parent->getData().size() - (Start - Parent->getData().data()),`
`479`	`477`	`Err);`
`480`	`478`
`481`	`479`	`// If we are pointed to real data, Start is not a nullptr, then there must be`