Skip to content

Commit e9301c2

Browse files
committed
address comments
1 parent 1898a43 commit e9301c2

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

mlir/include/mlir/Dialect/Ptr/IR/PtrOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ def Ptr_MaskedLoadOp : Pointer_Op<"masked_load", [
316316
attr-dict `:` qualified(type($ptr)) `->` type($result)
317317
}];
318318
let builders = [
319-
OpBuilder<(ins "Type":$resultType, "Value":$ptrs, "Value":$mask,
319+
OpBuilder<(ins "Type":$resultType, "Value":$ptr, "Value":$mask,
320320
"Value":$passthrough, CArg<"unsigned", "0">:$alignment)>
321321
];
322322
let hasVerifier = 1;

mlir/lib/Target/LLVMIR/Dialect/Ptr/PtrToLLVMIRTranslation.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -276,11 +276,6 @@ convertMaskedStoreOp(MaskedStoreOp maskedStoreOp, llvm::IRBuilderBase &builder,
276276
if (!value || !ptr || !mask)
277277
return maskedStoreOp.emitError("Failed to lookup operands");
278278

279-
// Get the value type.
280-
llvm::Type *valueType = value->getType();
281-
if (!valueType)
282-
return maskedStoreOp.emitError("Failed to get value type");
283-
284279
// Get the alignment.
285280
llvm::MaybeAlign alignment(maskedStoreOp.getAlignment().value_or(0));
286281

@@ -300,11 +295,6 @@ convertScatterOp(ScatterOp scatterOp, llvm::IRBuilderBase &builder,
300295
if (!value || !ptrs || !mask)
301296
return scatterOp.emitError("Failed to lookup operands");
302297

303-
// Get the value type
304-
llvm::Type *valueType = value->getType();
305-
if (!valueType)
306-
return scatterOp.emitError("Failed to get value type");
307-
308298
// Get the alignment.
309299
llvm::MaybeAlign alignment(scatterOp.getAlignment().value_or(0));
310300

0 commit comments

Comments
 (0)