fix unit-test

Author: denzor200

clang-tools-extra/clang-tidy/misc/ShadowedNamespaceFunctionCheck.cpp

@@ -72,14 +72,14 @@ void ShadowedNamespaceFunctionCheck::check(
   // Generate warning message
   std::string NamespaceName = ShadowedNamespace->getNameAsString();
   auto Diag = diag(Func->getLocation(), 
-                   "free function %0 shadows %1::%2")
+                   "free function %0 shadows '%1::%2'")
               << Func->getDeclName() 
               << NamespaceName 
-              << ShadowedFunc->getDeclName();
+              << ShadowedFunc->getDeclName().getAsString();
 
   // Generate fixit hint to add namespace qualification
   SourceLocation NameLoc = Func->getLocation();
-  if (NameLoc.isValid()) {
+  if (NameLoc.isValid() && !Func->getPreviousDecl()) {
     std::string Fix = NamespaceName + "::";
     Diag << FixItHint::CreateInsertion(NameLoc, Fix);
   }

clang-tools-extra/test/clang-tidy/checkers/misc/shadowed-namespace-function.cpp

@@ -6,8 +6,8 @@ namespace foo {
   void f1();
 }
 void f0() {}
-// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: free function 'f0' shadows foo::f0 [misc-shadowed-namespace-function]
+// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: free function 'f0' shadows 'foo::f0' [misc-shadowed-namespace-function]
 // CHECK-FIXES: void foo::f0() {}
 void f1() {}
-// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: free function 'f1' shadows foo::f1 [misc-shadowed-namespace-function]
+// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: free function 'f1' shadows 'foo::f1' [misc-shadowed-namespace-function]
 // CHECK-MESSAGES-NOT: :[[@LINE-2]]:{{.*}}: note: FIX-IT applied suggested code changes