Include sources can decay to pointer type

YutongZhuu · YutongZhuu · commit e9ea0be054d6 · 2025-03-16T16:46:32.000-04:00
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
@@ -11695,13 +11695,11 @@ void Sema::CheckImplicitConversion(Expr *E, QualType T, SourceLocation CC,
                              diag::warn_impcast_objective_c_literal_to_bool);
     }
     if (Source->isPointerType() || Source->canDecayToPointerType()) {
+      Diag(E->getExprLoc(), diag::warn_impcast_pointer_to_bool_strict);
       // Warn on pointer to bool conversion that is always true.
       DiagnoseAlwaysNonNullPointer(E, Expr::NPCK_NotNull, /*IsEqual*/ false,
                                    SourceRange(CC));
     }
-    if (Source->isPointerType()) {
-      Diag(E->getExprLoc(), diag::warn_impcast_pointer_to_bool_strict);
-    }
   }
 
   // If the we're converting a constant to an ObjC BOOL on a platform where BOOL

Original file line number	Diff line number	Diff line change
`@@ -11695,13 +11695,11 @@ void Sema::CheckImplicitConversion(Expr *E, QualType T, SourceLocation CC,`
`11695`	`11695`	`diag::warn_impcast_objective_c_literal_to_bool);`
`11696`	`11696`	`}`
`11697`	`11697`	`if (Source->isPointerType() \|\| Source->canDecayToPointerType()) {`
	`11698`	`+ Diag(E->getExprLoc(), diag::warn_impcast_pointer_to_bool_strict);`
`11698`	`11699`	`// Warn on pointer to bool conversion that is always true.`
`11699`	`11700`	`DiagnoseAlwaysNonNullPointer(E, Expr::NPCK_NotNull, /IsEqual/ false,`
`11700`	`11701`	`SourceRange(CC));`
`11701`	`11702`	`}`
`11702`		`- if (Source->isPointerType()) {`
`11703`		`- Diag(E->getExprLoc(), diag::warn_impcast_pointer_to_bool_strict);`
`11704`		`- }`
`11705`	`11703`	`}`
`11706`	`11704`
`11707`	`11705`	`// If the we're converting a constant to an ObjC BOOL on a platform where BOOL`