Address code review comments

Author: AmrDeveloper

clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h

@@ -149,8 +149,8 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
 
   mlir::Value createComplexReal(mlir::Location loc, mlir::Value operand) {
     auto resultType = operand.getType();
-    if (mlir::isa<cir::ComplexType>(resultType))
-      resultType = mlir::cast<cir::ComplexType>(resultType).getElementType();
+    if (auto complexResultType = mlir::dyn_cast<cir::ComplexType>(resultType))
+      resultType = complexResultType.getElementType();
     return cir::ComplexRealOp::create(*this, loc, resultType, operand);
   }
 

clang/include/clang/CIR/Dialect/IR/CIROps.td

@@ -3260,8 +3260,8 @@ def CIR_ComplexCreateOp : CIR_Op<"complex.create", [Pure, SameTypeOperands]> {
 def CIR_ComplexRealOp : CIR_Op<"complex.real", [Pure]> {
   let summary = "Extract the real part of a complex value";
   let description = [{
-    `cir.complex.real` operation takes an operand of `!cir.complex` or scalar
-    type and yields the real part of it.
+    `cir.complex.real` operation takes an operand of `!cir.complex`, `!cir.int`
+    or `!cir.float` type and yields the real part of it.
 
     Example:
 

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -2389,8 +2389,8 @@ OpFoldResult cir::ComplexCreateOp::fold(FoldAdaptor adaptor) {
 
 LogicalResult cir::ComplexRealOp::verify() {
   mlir::Type operandTy = getOperand().getType();
-  if (mlir::isa<cir::ComplexType>(operandTy)) {
-    operandTy = mlir::cast<cir::ComplexType>(operandTy).getElementType();
+  if (auto complexOperandTy = mlir::dyn_cast<cir::ComplexType>(operandTy)) {
+    operandTy = complexOperandTy.getElementType();
   }
 
   if (getType() != operandTy) {