Skip to content

Commit ea7c0db

Browse files
committed
[DirectX] replace byte splitting via vector bitcast with scalar
instructions - instead of bitcasting and extract element lets use trunc or trunc and logical shift right to split. - fixes #139020
1 parent 9cd5378 commit ea7c0db

File tree

2 files changed

+64
-0
lines changed

2 files changed

+64
-0
lines changed

llvm/lib/Target/DirectX/DXILLegalizePass.cpp

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
#include "DXILLegalizePass.h"
1010
#include "DirectX.h"
11+
#include "llvm/ADT/APInt.h"
12+
#include "llvm/IR/Constants.h"
1113
#include "llvm/IR/Function.h"
1214
#include "llvm/IR/IRBuilder.h"
1315
#include "llvm/IR/InstIterator.h"
@@ -510,6 +512,49 @@ static void updateFnegToFsub(Instruction &I,
510512
ToRemove.push_back(&I);
511513
}
512514

515+
static void
516+
legalizeGetHighLowi64Bytes(Instruction &I,
517+
SmallVectorImpl<Instruction *> &ToRemove,
518+
DenseMap<Value *, Value *> &ReplacedValues) {
519+
if (auto *BitCast = dyn_cast<BitCastInst>(&I)) {
520+
if (BitCast->getDestTy() ==
521+
FixedVectorType::get(Type::getInt32Ty(I.getContext()), 2) &&
522+
BitCast->getSrcTy()->isIntegerTy(64)) {
523+
ToRemove.push_back(BitCast);
524+
ReplacedValues[BitCast] = BitCast->getOperand(0);
525+
}
526+
}
527+
528+
if (auto *Extract = dyn_cast<ExtractElementInst>(&I)) {
529+
auto *VecTy = dyn_cast<FixedVectorType>(Extract->getVectorOperandType());
530+
if (VecTy && VecTy->getElementType()->isIntegerTy(32) &&
531+
VecTy->getNumElements() == 2) {
532+
if (auto *Index = dyn_cast<ConstantInt>(Extract->getIndexOperand())) {
533+
unsigned Idx = Index->getZExtValue();
534+
IRBuilder<> Builder(&I);
535+
assert(dyn_cast<BitCastInst>(Extract->getVectorOperand()));
536+
auto *Replacement = ReplacedValues[Extract->getVectorOperand()];
537+
if (Idx == 0) {
538+
Value *LowBytes = Builder.CreateTrunc(
539+
Replacement, Type::getInt32Ty(I.getContext()));
540+
ReplacedValues[Extract] = LowBytes;
541+
} else {
542+
assert(Idx == 1);
543+
Value *LogicalShiftRight = Builder.CreateLShr(
544+
Replacement,
545+
ConstantInt::get(
546+
Replacement->getType(),
547+
APInt(Replacement->getType()->getIntegerBitWidth(), 32)));
548+
Value *HighBytes = Builder.CreateTrunc(
549+
LogicalShiftRight, Type::getInt32Ty(I.getContext()));
550+
ReplacedValues[Extract] = HighBytes;
551+
}
552+
ToRemove.push_back(Extract);
553+
}
554+
}
555+
}
556+
}
557+
513558
namespace {
514559
class DXILLegalizationPipeline {
515560

@@ -544,6 +589,7 @@ class DXILLegalizationPipeline {
544589
LegalizationPipeline.push_back(legalizeMemCpy);
545590
LegalizationPipeline.push_back(removeMemSet);
546591
LegalizationPipeline.push_back(updateFnegToFsub);
592+
LegalizationPipeline.push_back(legalizeGetHighLowi64Bytes);
547593
}
548594
};
549595

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
2+
; RUN: opt -S -passes='dxil-legalize' -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s
3+
4+
define void @split_via_extract(i64 noundef %a) {
5+
; CHECK-LABEL: define void @split_via_extract(
6+
; CHECK-SAME: i64 noundef [[A:%.*]]) {
7+
; CHECK-NEXT: [[ENTRY:.*:]]
8+
; CHECK-NEXT: [[TMP0:%.*]] = trunc i64 [[A]] to i32
9+
; CHECK-NEXT: [[TMP1:%.*]] = lshr i64 [[A]], 32
10+
; CHECK-NEXT: [[TMP2:%.*]] = trunc i64 [[TMP1]] to i32
11+
; CHECK-NEXT: ret void
12+
;
13+
entry:
14+
%vecA = bitcast i64 %a to <2 x i32>
15+
%low = extractelement <2 x i32> %vecA, i32 0 ; low 32 bits
16+
%high = extractelement <2 x i32> %vecA, i32 1 ; high 32 bits
17+
ret void
18+
}

0 commit comments

Comments
 (0)