omit ByName as suggested

Author: mingmingl-llvm

lld/ELF/Writer.cpp

@@ -554,9 +554,8 @@ template <class ELFT> void Writer<ELFT>::addSectionSymbols() {
 }
 
 // Returns true if the section is a data section that's read only and
-// relocatable per its section name. Note this function doesn't look at section
-// sh_type or sh_flags.
-static bool isRelRoDataSectionByName(Ctx &ctx, StringRef SectionName) {
+// relocatable per its section name.
+static bool isRelRoDataSection(Ctx &ctx, StringRef SectionName) {
   //  If  -z keep-data-section-prefix is given, '<section>.hot' and
   //  '<section>.unlikely' is considered a split of '<section>' based on
   //  hotness. They should share the same section attributes.
@@ -646,7 +645,7 @@ static bool isRelroSection(Ctx &ctx, const OutputSection *sec) {
   // magic section names.
   StringRef s = sec->name;
 
-  bool abiAgnostic = isRelRoDataSectionByName(ctx, s) || s == ".bss.rel.ro" ||
+  bool abiAgnostic = isRelRoDataSection(ctx, s) || s == ".bss.rel.ro" ||
                      s == ".ctors" || s == ".dtors" || s == ".jcr" ||
                      s == ".eh_frame" || s == ".fini_array" ||
                      s == ".init_array" || s == ".preinit_array";