Skip to content

Commit eb4fcfc

Browse files
committed
Address comments
1 parent 95868ea commit eb4fcfc

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

clang/include/clang/Basic/AttrDocs.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1158,7 +1158,7 @@ Query for this feature with ``__has_attribute(diagnose_if)``.
11581158
def NoSpecializationsDocs : Documentation {
11591159
let Category = DocCatDecl;
11601160
let Content = [{
1161-
``[[clang::no_specializations]]`` can be applied to function, class or variable
1161+
``[[clang::no_specializations]]`` can be applied to function, class, or variable
11621162
templates which should not be explicitly specialized by users. This is primarily
11631163
used to diagnose user specializations of standard library type traits.
11641164
}];

clang/include/clang/Basic/DiagnosticGroups.td

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,6 @@ def ExpansionToDefined : DiagGroup<"expansion-to-defined">;
475475
def FlagEnum : DiagGroup<"flag-enum">;
476476
def IncrementBool : DiagGroup<"increment-bool", [DeprecatedIncrementBool]>;
477477
def InfiniteRecursion : DiagGroup<"infinite-recursion">;
478-
def InvalidSpecialization : DiagGroup<"invalid-specialization">;
479478
def PureVirtualCallFromCtorDtor: DiagGroup<"call-to-pure-virtual-from-ctor-dtor">;
480479
def GNUImaginaryConstant : DiagGroup<"gnu-imaginary-constant">;
481480
def IgnoredGCH : DiagGroup<"ignored-gch">;
@@ -1590,4 +1589,3 @@ def ExplicitSpecializationStorageClass : DiagGroup<"explicit-specialization-stor
15901589

15911590
// A warning for options that enable a feature that is not yet complete
15921591
def ExperimentalOption : DiagGroup<"experimental-option">;
1593-

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5447,7 +5447,7 @@ def note_dependent_function_template_spec_discard_reason : Note<
54475447
"namespace; did you mean to explicitly qualify the specialization?}1}0">;
54485448
def warn_invalid_specialization : Warning<
54495449
"%0 cannot be specialized%select{|: %2}1">,
5450-
DefaultError, InGroup<InvalidSpecialization>;
5450+
DefaultError, InGroup<DiagGroup<"invalid-specialization">>;
54515451
def note_marked_here : Note<"marked %0 here">;
54525452

54535453
// C++ class template specializations and out-of-line definitions

0 commit comments

Comments
 (0)