[lld][ELF] Allow implicit wildcard in archive file name

Author: amosher-nvidia

lld/ELF/LinkerScript.h

@@ -195,6 +195,7 @@ class SectionPattern {
 
 class InputSectionDescription : public SectionCommand {
   SingleStringMatcher filePat;
+  SmallString<0> implicitArchiveWildcardPat;
 
   // Cache of the most recent input argument and result of matchesFile().
   mutable std::optional<std::pair<const InputFile *, bool>> matchesFileCache;
@@ -203,9 +204,19 @@ class InputSectionDescription : public SectionCommand {
   InputSectionDescription(StringRef filePattern, uint64_t withFlags = 0,
                           uint64_t withoutFlags = 0, StringRef classRef = {})
       : SectionCommand(InputSectionKind), filePat(filePattern),
-        classRef(classRef), withFlags(withFlags), withoutFlags(withoutFlags) {
+        implicitArchiveWildcardPat(), classRef(classRef), withFlags(withFlags),
+        withoutFlags(withoutFlags) {
     assert((filePattern.empty() || classRef.empty()) &&
            "file pattern and class reference are mutually exclusive");
+
+    // Fixes up the input file pattern, adding an implicit wildcard
+    // if the trailing character is an ':' to allow matching entire archives
+    if (!filePattern.empty() && filePattern.back() == ':') {
+      implicitArchiveWildcardPat.reserve(filePattern.size() + 1);
+      implicitArchiveWildcardPat.append(filePattern);
+      implicitArchiveWildcardPat.push_back('*');
+      filePat = SingleStringMatcher(implicitArchiveWildcardPat);
+    }
   }
 
   static bool classof(const SectionCommand *c) {

lld/test/ELF/linkerscript/filename-spec.s

@@ -55,7 +55,7 @@
 # RUN: llvm-objdump -s 8 | FileCheck --check-prefix=SECONDFIRST %s
 
 ## Verify matching of archive library names in KEEP.
-# RUN: echo 'SECTIONS{.foo :{ KEEP(*lib2*(.foo)) KEEP(*lib1*(.foo)) }}' > 9.t
+# RUN: echo 'SECTIONS{.foo :{ KEEP(*lib2.a:(.foo)) KEEP(*lib1*(.foo)) }}' > 9.t
 # RUN: ld.lld -o 9 -T 9.t --whole-archive \
 # RUN:   dir1/lib1.a dir2/lib2.a
 # RUN: llvm-objdump -s 9 | FileCheck --check-prefix=SECONDFIRST %s