Skip to content

Commit ebbda8d

Browse files
committed
make fields optional
1 parent f55ea59 commit ebbda8d

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lldb/include/lldb/Core/Telemetry.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ struct CommandInfo : public LLDBBaseTelemetryInfo {
9696
/// Vendor may allow them by setting the
9797
/// LLDBConfig::detailed_command_telemetry.
9898
/// @{
99-
std::string original_command;
100-
std::string args;
99+
std::optional<std::string> original_command;
100+
std::optional<std::string> args;
101101
/// @}
102102
/// Return status of a command and any error description in case of error.
103103
std::optional<lldb::ReturnStatus> ret_status;

lldb/source/Core/Telemetry.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,10 @@ void CommandInfo::serialize(Serializer &serializer) const {
6666
serializer.write("target_uuid", target_uuid.GetAsString());
6767
serializer.write("command_id", command_id);
6868
serializer.write("command_name", command_name);
69-
serializer.write("original_command", original_command);
70-
serializer.write("args", args);
69+
if (original_command.has_value())
70+
serializer.write("original_command", original_command);
71+
if (args.has_value())
72+
serializer.write("args", args);
7173
if (ret_status.has_value())
7274
serializer.write("ret_status", ret_status.value());
7375
if (error_data.has_value())

0 commit comments

Comments
 (0)