refactor: separate sign_bit from out_e

krishna2803 · krishna2803 · commit ebdaeac6d0e0 · 2025-03-22T05:51:01.000+05:30
Signed-off-by: krishna2803 &lt;kpandey81930@gmail.com&gt;
diff --git a/libc/src/math/generic/cbrtf16.cpp b/libc/src/math/generic/cbrtf16.cpp
@@ -95,7 +95,7 @@ LLVM_LIBC_FUNCTION(float16, cbrtf16, (float16 x)) {
   FloatBits xf_bits(xf);
 
   unsigned x_e = static_cast<unsigned>(xf_bits.get_exponent());
-  unsigned out_e = (x_e / 3 + 127) | sign_bit;
+  unsigned out_e = x_e / 3 + 127;
 
   unsigned shift_e = x_e % 3;
 
@@ -155,8 +155,8 @@ LLVM_LIBC_FUNCTION(float16, cbrtf16, (float16 x)) {
     fputil::clear_except_if_required(FE_INEXACT);
   }
 
-  uint32_t r_bits =
-      r_m | (static_cast<uint32_t>(out_e) << FloatBits::FRACTION_LEN);
+  uint32_t r_bits = r_m | (static_cast<uint32_t>(out_e | sign_bit)
+                           << FloatBits::FRACTION_LEN);
 
   return static_cast<float16>(FloatBits(r_bits).get_val());
 }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ LLVM_LIBC_FUNCTION(float16, cbrtf16, (float16 x)) {`
`95`	`95`	`FloatBits xf_bits(xf);`
`96`	`96`
`97`	`97`	`unsigned x_e = static_cast<unsigned>(xf_bits.get_exponent());`
`98`		`- unsigned out_e = (x_e / 3 + 127) \| sign_bit;`
	`98`	`+ unsigned out_e = x_e / 3 + 127;`
`99`	`99`
`100`	`100`	`unsigned shift_e = x_e % 3;`
`101`	`101`
`@@ -155,8 +155,8 @@ LLVM_LIBC_FUNCTION(float16, cbrtf16, (float16 x)) {`
`155`	`155`	`fputil::clear_except_if_required(FE_INEXACT);`
`156`	`156`	`}`
`157`	`157`
`158`		`- uint32_t r_bits =`
`159`		`- r_m \| (static_cast<uint32_t>(out_e) << FloatBits::FRACTION_LEN);`
	`158`	`+ uint32_t r_bits = r_m \| (static_cast<uint32_t>(out_e \| sign_bit)`
	`159`	`+ << FloatBits::FRACTION_LEN);`
`160`	`160`
`161`	`161`	`return static_cast<float16>(FloatBits(r_bits).get_val());`
`162`	`162`	`}`