Addressing review feedback

parsifal-47 · parsifal-47 · commit ec12ecd1dd93 · 2024-12-20T03:57:13.000Z
diff --git a/llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp b/llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
@@ -2109,7 +2109,7 @@ bool MipsAsmParser::processInstruction(MCInst &Inst, SMLoc IDLoc,
     warnIfNoMacro(IDLoc);
 
     if (!Inst.getOperand(0).isExpr()) {
-      return Error(IDLoc, "jal needs a symbolic expression in PIC mode");
+      return Error(IDLoc, "unsupported constant in relocation");
     }
 
     const MCExpr *JalExpr = Inst.getOperand(0).getExpr();

Original file line number	Diff line number	Diff line change
`@@ -2109,7 +2109,7 @@ bool MipsAsmParser::processInstruction(MCInst &Inst, SMLoc IDLoc,`
`2109`	`2109`	`warnIfNoMacro(IDLoc);`
`2110`	`2110`
`2111`	`2111`	`if (!Inst.getOperand(0).isExpr()) {`
`2112`		`- return Error(IDLoc, "jal needs a symbolic expression in PIC mode");`
	`2112`	`+ return Error(IDLoc, "unsupported constant in relocation");`
`2113`	`2113`	`}`
`2114`	`2114`
`2115`	`2115`	`const MCExpr *JalExpr = Inst.getOperand(0).getExpr();`