Skip to content

Commit ec35781

Browse files
committed
Addressing review feedback
1 parent 7216aa1 commit ec35781

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

mlir/lib/Transforms/RemoveDeadValues.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,10 @@ static void processSimpleOp(Operation *op, RunLivenessAnalysis &la,
242242
/// (1) Adding its non-live arguments to a list for future removal.
243243
/// (2) Marking their corresponding operands in its callers for removal.
244244
/// (3) Identifying and enqueueing unnecessary terminator operands
245-
/// (return values that are non-live across all callers) for removal.
245+
/// (return values that are non-live across all callers) for removal.
246246
/// (4) Enqueueing the non-live arguments and return values for removal.
247247
/// (5) Collecting the uses of these return values in its callers for future
248-
/// removal.
248+
/// removal.
249249
/// (6) Marking all its results as non-live values.
250250
static void processFuncOp(FunctionOpInterface funcOp, Operation *module,
251251
RunLivenessAnalysis &la, DenseSet<Value> &nonLiveSet,
@@ -344,21 +344,21 @@ static void processFuncOp(FunctionOpInterface funcOp, Operation *module,
344344
///
345345
/// Scenario 2: Otherwise:
346346
/// (1) Collect its unnecessary operands (operands forwarded to unnecessary
347-
/// results or arguments).
347+
/// results or arguments).
348348
/// (2) Process each of its regions.
349349
/// (3) Collect the uses of its unnecessary results (results forwarded from
350-
/// unnecessary operands
351-
/// or terminator operands).
350+
/// unnecessary operands
351+
/// or terminator operands).
352352
/// (4) Add these results to the deletion list.
353353
///
354354
/// Processing a region includes:
355355
/// (a) Collecting the uses of its unnecessary arguments (arguments forwarded
356-
/// from unnecessary operands
357-
/// or terminator operands).
356+
/// from unnecessary operands
357+
/// or terminator operands).
358358
/// (b) Collecting these unnecessary arguments.
359359
/// (c) Collecting its unnecessary terminator operands (terminator operands
360-
/// forwarded to unnecessary results
361-
/// or arguments).
360+
/// forwarded to unnecessary results
361+
/// or arguments).
362362
///
363363
/// Value Flow Note: In this operation, values flow as follows:
364364
/// - From operands and terminator operands (successor operands)
@@ -637,9 +637,9 @@ static void processRegionBranchOp(RegionBranchOpInterface regionBranchOp,
637637
/// Iterate through each successor block of `branchOp`.
638638
/// (1) For each successor block, gather all operands from all successors.
639639
/// (2) Fetch their associated liveness analysis data and collect for future
640-
/// removal.
640+
/// removal.
641641
/// (3) Identify and collect the dead operands from the successor block
642-
/// as well as their corresponding arguments.
642+
/// as well as their corresponding arguments.
643643

644644
static void processBranchOp(BranchOpInterface branchOp, RunLivenessAnalysis &la,
645645
DenseSet<Value> &nonLiveSet,

0 commit comments

Comments
 (0)