clean up

Author: vinay-deshmukh

libc/CMakeLists.txt

@@ -34,9 +34,6 @@ if (CMAKE_BUILD_TYPE STREQUAL "Debug")
   add_definitions("-D_DEBUG")
 endif()
 
-# temporary! only for this PR to catch warnings in CI
-add_compile_options("-Werror=implicit-const-int-float-conversion")
-
 # Default to C++17
 set(CMAKE_CXX_STANDARD 17)
 

libc/cmake/modules/LLVMLibCTestRules.cmake

@@ -37,7 +37,6 @@ function(_get_common_test_compile_options output_var c_test flags)
       # list(APPEND compile_options "-Werror")
     endif()
     list(APPEND compile_options "-Wconversion")
-    # list(APPEND compile_options "-Wno-sign-conversion")
     list(APPEND compile_options "-Wimplicit-fallthrough")
     list(APPEND compile_options "-Wwrite-strings")
     # Silence this warning because _Complex is a part of C99.