Skip to content

Commit ed034ea

Browse files
Address comments
1 parent f35a467 commit ed034ea

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,8 @@ class SeedContainer {
225225
/// instructions.
226226

227227
// TODO: Range_size counts fully used-bundles. Further, iterating over
228-
// anything other than the Bundles in a SeedContainer includes used seeds,
229-
// so for now just check that removing all the seeds from a bundle also
230-
// empties the bundle. Rework the iterator logic to clean this up.
228+
// anything other than the Bundles in a SeedContainer includes used
229+
// seeds. Rework the iterator logic to clean this up.
231230
iterator(BundleMapT &Map, BundleMapT::iterator MapIt, ValT *Vec, int VecIdx)
232231
: Map(&Map), MapIt(MapIt), Vec(Vec), VecIdx(VecIdx) {}
233232
value_type &operator*() {

llvm/unittests/Transforms/Vectorize/SandboxVectorizer/SeedCollectorTest.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -374,11 +374,12 @@ define void @foo(ptr noalias %ptr, float %val) {
374374
// Expect just one vector of store seeds
375375
EXPECT_EQ(range_size(StoreSeedsRange), 1u);
376376
ExpectThatElementsAre(SB, {St0, St1, St2, St3});
377-
// Check that the EraseInstr callback works. TODO: Range_size counts fully
378-
// used-bundles even though the iterator skips them. Further, iterating over
379-
// anything other than the Bundles in a SeedContainer includes used seeds. So
380-
// for now just check that removing all the seeds from a bundle also empties
381-
// the bundle.
377+
// Check that the EraseInstr callback works.
378+
379+
// TODO: Range_size counts fully used-bundles even though the iterator skips
380+
// them. Further, iterating over anything other than the Bundles in a
381+
// SeedContainer includes used seeds. So for now just check that removing all
382+
// the seeds from a bundle also empties the bundle.
382383
St0->eraseFromParent();
383384
St1->eraseFromParent();
384385
St2->eraseFromParent();

0 commit comments

Comments
 (0)