Adding unit tests for CapabilitiesEventBody serialization logic.

Author: ashgti

lldb/tools/lldb-dap/Protocol/ProtocolTypes.h

@@ -249,36 +249,39 @@ llvm::json::Value toJSON(const AdapterFeature &);
 /// Information about the capabilities of a debug adapter.
 struct Capabilities {
   /// The supported features for this adapter.
-  llvm::DenseSet<AdapterFeature> supportedFeatures;
+  llvm::DenseSet<AdapterFeature> supportedFeatures{};
 
   /// Available exception filter options for the `setExceptionBreakpoints`
   /// request.
   std::optional<std::vector<ExceptionBreakpointsFilter>>
-      exceptionBreakpointFilters;
+      exceptionBreakpointFilters{};
 
   /// The set of characters that should trigger completion in a REPL. If not
   /// specified, the UI should assume the `.` character.
-  std::optional<std::vector<std::string>> completionTriggerCharacters;
+  std::optional<std::vector<std::string>> completionTriggerCharacters =
+      std::nullopt;
 
   /// The set of additional module information exposed by the debug adapter.
-  std::optional<std::vector<ColumnDescriptor>> additionalModuleColumns;
+  std::optional<std::vector<ColumnDescriptor>> additionalModuleColumns =
+      std::nullopt;
 
   /// Checksum algorithms supported by the debug adapter.
-  std::optional<std::vector<ChecksumAlgorithm>> supportedChecksumAlgorithms;
+  std::optional<std::vector<ChecksumAlgorithm>> supportedChecksumAlgorithms =
+      std::nullopt;
 
   /// Modes of breakpoints supported by the debug adapter, such as 'hardware' or
   /// 'software'. If present, the client may allow the user to select a mode and
   /// include it in its `setBreakpoints` request.
   ///
   /// Clients may present the first applicable mode in this array as the
   /// 'default' mode in gestures that set breakpoints.
-  std::optional<std::vector<BreakpointMode>> breakpointModes;
+  std::optional<std::vector<BreakpointMode>> breakpointModes = std::nullopt;
 
   /// lldb-dap Extensions
   /// @{
 
   /// The version of the adapter.
-  std::optional<std::string> lldbExtVersion;
+  std::optional<std::string> lldbExtVersion = std::nullopt;
 
   /// @}
 };

lldb/unittests/DAP/ProtocolTypesTest.cpp

@@ -7,12 +7,14 @@
 //===----------------------------------------------------------------------===//
 
 #include "Protocol/ProtocolTypes.h"
+#include "Protocol/ProtocolEvents.h"
 #include "Protocol/ProtocolRequests.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/Support/JSON.h"
 #include "llvm/Testing/Support/Error.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"
+#include <optional>
 
 using namespace llvm;
 using namespace lldb;
@@ -666,3 +668,18 @@ TEST(ProtocolTypesTest, ThreadResponseBody) {
   // Validate toJSON
   EXPECT_EQ(json, pp(body));
 }
+
+TEST(ProtocolTypesTest, CapabilitiesEventBody) {
+  const CapabilitiesEventBody body{Capabilities{/*supportedFeatures=*/{
+      eAdapterFeatureANSIStyling,
+      eAdapterFeatureBreakpointLocationsRequest,
+  }}};
+  const StringRef json = R"({
+  "capabilities": {
+    "supportsANSIStyling": true,
+    "supportsBreakpointLocationsRequest": true
+  }
+})";
+  // Validate toJSON
+  EXPECT_EQ(json, pp(body));
+}