handle refs

Author: segoon

clang-tools-extra/clang-tidy/bugprone/TaxiAsyncUseAfterFreeCheck.cpp

@@ -42,6 +42,11 @@ void TaxiAsyncUseAfterFreeCheck::check(const MatchFinder::MatchResult& Result) {
       continue;
 
     const ValueDecl* CapturedVarDecl = Capture.getCapturedVar();
+    if (CapturedVarDecl->getType().getCanonicalType()->isLValueReferenceType() ||
+        CapturedVarDecl->getType().getCanonicalType()->isRValueReferenceType()) {
+      continue;
+    }
+
     if (CapturedVarDecl->getLocation() >= TasksLocation) {
       diag(Capture.getLocation(), "captured here");
       diag(CapturedVarDecl->getLocation(), "variable can be used after free");

clang-tools-extra/test/clang-tidy/checkers/bugprone/taxi-async-use-after-free.cpp

@@ -28,8 +28,26 @@ void f_ok() {
 
 void f_use_after_free() {
   std::vector<int> v;
+  // CHECK-MESSAGES: :[[@LINE-1]]:20: warning: std::vector<Task> can die after variable [bugprone-taxi-async-use-after-free]
   int x = 1;
+  // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: variable can be used after free [bugprone-taxi-async-use-after-free]
 
   v.push_back(engine::Async([&x]{ x = 2;}));
+  // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: captured here [bugprone-taxi-async-use-after-free]
 }
 
+void f_ref() {
+  int xx = 1;
+  std::vector<int> v;
+  int &x = x;
+
+  v.push_back(engine::Async([&x]{ x = 2;}));
+}
+
+void f_ref_ref() {
+  int xx = 1;
+  std::vector<int> v;
+  int &&x = static_cast<int&&>(xx);
+
+  v.push_back(engine::Async([&x]{ x = 2;}));
+}