Addressed review comment

Author: HemangGadhavi

lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp

@@ -77,7 +77,7 @@ bool DWARFFormValue::ExtractValue(const DWARFDataExtractor &data,
     case DW_FORM_strp:
     case DW_FORM_line_strp:
     case DW_FORM_sec_offset:
-      assert(m_unit); // Unit must be valid
+      assert(m_unit);
       ref_addr_size = m_unit->GetFormParams().getDwarfOffsetByteSize();
       m_value.uval = data.GetMaxU64(offset_ptr, ref_addr_size);
       break;
@@ -284,7 +284,7 @@ bool DWARFFormValue::SkipValue(dw_form_t form,
     case DW_FORM_sec_offset:
     case DW_FORM_strp:
     case DW_FORM_line_strp:
-      assert(unit); // Unit must be valid
+      assert(unit);
       ref_addr_size = unit->GetFormParams().getDwarfOffsetByteSize();
       *offset_ptr += ref_addr_size;
       return true;

lldb/unittests/SymbolFile/DWARF/DWARF64UnitTest.cpp

@@ -38,10 +38,6 @@ TEST(DWARF64UnitTest, DWARF64DebugInfoAndCU) {
               Form:            DW_FORM_data2
             - Attribute:       DW_AT_stmt_list 
               Form:            DW_FORM_sec_offset 
-            - Attribute:       DW_AT_low_pc
-              Form:            DW_FORM_addr
-            - Attribute:       DW_AT_high_pc
-              Form:            DW_FORM_data4
         - Code:            0x02
           Tag:             DW_TAG_subprogram 
           Children:        DW_CHILDREN_no
@@ -59,8 +55,6 @@ TEST(DWARF64UnitTest, DWARF64DebugInfoAndCU) {
             - Value:           0x0
             - Value:           0x04
             - Value:           0x0
-            - Value:	       0xdeadbeef
-            - Value:	       0xdeadbeef
         - AbbrCode:        0x2
           Values:
             - Value:           0x1
@@ -84,10 +78,6 @@ TEST(DWARF64UnitTest, DWARF64DebugInfoAndCU) {
   auto attrs = cu_entry->GetAttributes(unit, DWARFDebugInfoEntry::Recurse::yes);
   attrs.ExtractFormValueAtIndex(2, form_value); // Validate DW_AT_stmt_list
   ASSERT_EQ(form_value.Unsigned(), 0UL);
-  attrs.ExtractFormValueAtIndex(3, form_value); // Validate DW_AT_low_pc
-  ASSERT_EQ(form_value.Unsigned(), 0xdeadbeef);
-  attrs.ExtractFormValueAtIndex(4, form_value); // Validate DW_AT_high_pc
-  ASSERT_EQ(form_value.Unsigned(), 0xdeadbeef);
 
   DWARFDIE cu_die(unit, cu_entry);
   auto declaration = cu_die.GetFirstChild();