Same symbols indices doesn't mean sections are good

Author: e-kud

llvm/lib/ObjCopy/COFF/COFFWriter.cpp

@@ -109,9 +109,7 @@ Error COFFWriter::finalizeSymIdxContents() {
 
   DenseMap<size_t, size_t> SymIdMap;
   SmallDenseMap<ssize_t, coff_aux_section_definition *, 4> SecIdMap;
-  bool NeedUpdate = false;
   for (Symbol &Sym : Obj.getMutableSymbols()) {
-    NeedUpdate |= Sym.OriginalRawIndex != Sym.RawIndex;
     SymIdMap[Sym.OriginalRawIndex] = Sym.RawIndex;
 
     // We collect only definition symbols of the sections to update checksum.
@@ -123,9 +121,6 @@ Error COFFWriter::finalizeSymIdxContents() {
               Sym.AuxData[0].Opaque);
   }
 
-  if (!NeedUpdate)
-    return Error::success();
-
   for (Section &Sec : Obj.getMutableSections()) {
     if (!IsSymIdxSection(Sec.Name))
       continue;