addressing PR comments

joaosaffran · joaosaffran · commit eeffded2ee6b · 2025-06-03T17:39:27.000Z
diff --git a/llvm/lib/Target/DirectX/DXILRootSignature.cpp b/llvm/lib/Target/DirectX/DXILRootSignature.cpp
@@ -234,6 +234,8 @@ static bool verifyRegisterValue(uint32_t RegisterValue) {
   return RegisterValue != ~0U;
 }
 
+// This Range is reserverved, therefore invalid, according to the spec
+// https://github.com/llvm/wg-hlsl/blob/main/proposals/0002-root-signature-in-clang.md#all-the-values-should-be-legal
 static bool verifyRegisterSpace(uint32_t RegisterSpace) {
   return !(RegisterSpace >= 0xFFFFFFF0 && RegisterSpace <= 0xFFFFFFFF);
 }

Original file line number	Diff line number	Diff line change
`@@ -234,6 +234,8 @@ static bool verifyRegisterValue(uint32_t RegisterValue) {`
`234`	`234`	`return RegisterValue != ~0U;`
`235`	`235`	`}`
`236`	`236`
	`237`	`+// This Range is reserverved, therefore invalid, according to the spec`
	`238`	`+// https://github.com/llvm/wg-hlsl/blob/main/proposals/0002-root-signature-in-clang.md#all-the-values-should-be-legal`
`237`	`239`	`static bool verifyRegisterSpace(uint32_t RegisterSpace) {`
`238`	`240`	`return !(RegisterSpace >= 0xFFFFFFF0 && RegisterSpace <= 0xFFFFFFFF);`
`239`	`241`	`}`