Skip to content

Commit efb8458

Browse files
wenju-hebader
andauthored
[clang][SPIR][SPIRV] Don't generate constant NULL from addrspacecast generic NULL (#165353)
Fix a regression caused by 1ffff05. OpenCL/SPIRV generic address space doesn't cover constant address space. --------- Co-authored-by: Alexey Bader <[email protected]>
1 parent e75af45 commit efb8458

File tree

3 files changed

+737
-634
lines changed

3 files changed

+737
-634
lines changed

clang/lib/CodeGen/Targets/SPIR.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ CommonSPIRTargetCodeGenInfo::getNullPointer(const CodeGen::CodeGenModule &CGM,
260260
LangAS AS = QT->getUnqualifiedDesugaredType()->isNullPtrType()
261261
? LangAS::Default
262262
: QT->getPointeeType().getAddressSpace();
263-
if (AS == LangAS::Default || AS == LangAS::opencl_generic)
263+
if (AS == LangAS::Default || AS == LangAS::opencl_generic ||
264+
AS == LangAS::opencl_constant)
264265
return llvm::ConstantPointerNull::get(PT);
265266

266267
auto &Ctx = CGM.getContext();

0 commit comments

Comments
 (0)