Skip to content

Commit f034d90

Browse files
committed
review comments fix
1 parent 86f2023 commit f034d90

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

llvm/lib/DebugInfo/Symbolize/Symbolize.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,6 @@ LLVMSymbolizer::loadOrGetBinary(const std::string &Path) {
579579

580580
Expected<OwningBinary<Binary>> BinOrErr = createBinary(Path);
581581
if (!BinOrErr) {
582-
BinaryForPath.erase(Pair.first);
583582
return BinOrErr.takeError();
584583
}
585584

llvm/test/DebugInfo/symbolize-big-archive-elf.test

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,3 @@
2525
// CHECK-NOTARCHIVE: error: '{{.*}}' is not a valid archive
2626
// RUN: not llvm-symbolizer --obj="%t.a()" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-EMPTY
2727
// CHECK-EMPTY: {{.*}}no matching member{{.*}}
28-
// RUN: not llvm-symbolizer --obj="%t.a(%t.o" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-1
29-
// CHECK-INCORRECT-FORMAT-1: {{.*}}No such file or directory{{.*}}
30-
// RUN: not llvm-symbolizer --obj="%t.a%t.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-2
31-
// CHECK-INCORRECT-FORMAT-2: {{.*}}Not a directory{{.*}}

llvm/test/DebugInfo/symbolize-big-archive-xcoff.test

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,3 @@
3333
// CHECK-NOTARCHIVE: error: '{{.*}}' is not a valid archive
3434
// RUN: not llvm-symbolizer --obj="%t.a()" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-EMPTY
3535
// CHECK-EMPTY: {{.*}}no matching member{{.*}}
36-
// RUN: not llvm-symbolizer --obj="%t.a(%t.o" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-1
37-
// CHECK-INCORRECT-FORMAT-1: {{.*}}No such file or directory{{.*}}
38-
// RUN: not llvm-symbolizer --obj="%t.a%t.o)" 0x1000 2>&1 | FileCheck %s --check-prefix=CHECK-INCORRECT-FORMAT-2
39-
// CHECK-INCORRECT-FORMAT-2: {{.*}}Not a directory{{.*}}
40-

0 commit comments

Comments
 (0)