Fix reviewer comments

Author: winner245

libcxx/docs/Status/Cxx23Issues.csv

@@ -137,7 +137,7 @@
 "`LWG3593 <https://wg21.link/LWG3593>`__","Several iterators' ``base() const &`` and ``lazy_split_view::outer-iterator::value_type::end()`` missing ``noexcept``","2021-10 (Virtual)","","",""
 "`LWG3595 <https://wg21.link/LWG3595>`__","Exposition-only classes proxy and postfix-proxy for ``common_iterator`` should be fully ``constexpr``","2021-10 (Virtual)","|Complete|","14",""
 "","","","","",""
-"`LWG3088 <https://wg21.link/LWG3088>`__","``forward_list::merge`` behaviour unclear when passed ``*this``","2022-02 (Virtual)","|Complete|","21",""
+"`LWG3088 <https://wg21.link/LWG3088>`__","``forward_list::merge`` behaviour unclear when passed ``*this``","2022-02 (Virtual)","|Complete|","Yes",""
 "`LWG3471 <https://wg21.link/LWG3471>`__","``polymorphic_allocator::allocate`` does not satisfy ``Cpp17Allocator`` requirements","2022-02 (Virtual)","","",""
 "`LWG3525 <https://wg21.link/LWG3525>`__","``uses_allocator_construction_args`` fails to handle types convertible to ``pair``","2022-02 (Virtual)","","",""
 "`LWG3598 <https://wg21.link/LWG3598>`__","``system_category().default_error_condition(0)`` is underspecified","2022-02 (Virtual)","","",""

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/merge_lvalue.pass.cpp

@@ -9,7 +9,6 @@
 // <forward_list>
 
 // void merge(forward_list& x);
-// If (addressof(x) == this) does nothing; otherwise ...
 
 #include <forward_list>
 #include <iterator>
@@ -112,9 +111,9 @@ int main(int, char**) {
 
   { // Make sure self-merging does nothing.
     int a[] = {1, 2, 3, 4, 5};
-    std::forward_list<int> c(a, a + sizeof(a) / sizeof(a[0]));
+    std::forward_list<int> c(std::begin(a), std::end(a));
     c.merge(c);
-    assert((c == std::forward_list<int>(a, a + sizeof(a) / sizeof(a[0]))));
+    assert(c == std::forward_list<int>(std::begin(a), std::end(a)));
   }
 
   return 0;

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/merge_lvalue_pred.pass.cpp

@@ -9,7 +9,6 @@
 // <forward_list>
 
 // template <class Compare> void merge(forward_list& x, Compare comp);
-// If (addressof(x) == this) does nothing; otherwise ...
 
 #include <forward_list>
 #include <iterator>
@@ -92,6 +91,7 @@ int main(int, char**) {
     C c3(std::begin(t3), std::end(t3));
     assert(c1 == c3);
   }
+
 #if TEST_STD_VER >= 11
   { // Test with a different allocator.
     typedef int T;
@@ -112,9 +112,9 @@ int main(int, char**) {
 
   { // Make sure self-merging does nothing.
     int a[] = {5, 4, 3, 2, 1};
-    std::forward_list<int> c(a, a + sizeof(a) / sizeof(a[0]));
+    std::forward_list<int> c(std::begin(a), std::end(a));
     c.merge(c, std::greater<int>());
-    assert((c == std::forward_list<int>(a, a + sizeof(a) / sizeof(a[0]))));
+    assert(c == std::forward_list<int>(std::begin(a), std::end(a)));
   }
 
   return 0;

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/merge_rvalue.pass.cpp

@@ -11,7 +11,6 @@
 // <forward_list>
 
 // void merge(forward_list&& x);
-// If (addressof(x) == this) does nothing; otherwise ...
 
 #include <forward_list>
 #include <functional>
@@ -105,9 +104,9 @@ int main(int, char**) {
 
   { // Make sure self-merging does nothing.
     int a[] = {1, 2, 3, 4, 5};
-    std::forward_list<int> c(a, a + sizeof(a) / sizeof(a[0]));
+    std::forward_list<int> c(std::begin(a), std::end(a));
     c.merge(std::move(c));
-    assert((c == std::forward_list<int>(a, a + sizeof(a) / sizeof(a[0]))));
+    assert(c == std::forward_list<int>(std::begin(a), std::end(a)));
   }
 
   return 0;

libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/merge_rvalue_pred.pass.cpp

@@ -11,7 +11,6 @@
 // <forward_list>
 
 // template <class Compare> void merge(forward_list&& x, Compare comp);
-// If (addressof(x) == this) does nothing; otherwise ...
 
 #include <forward_list>
 #include <functional>
@@ -106,9 +105,9 @@ int main(int, char**) {
 
   { // Make sure self-merging does nothing.
     int a[] = {5, 4, 3, 2, 1};
-    std::forward_list<int> c(a, a + sizeof(a) / sizeof(a[0]));
+    std::forward_list<int> c(std::begin(a), std::end(a));
     c.merge(std::move(c), std::greater<int>());
-    assert((c == std::forward_list<int>(a, a + sizeof(a) / sizeof(a[0]))));
+    assert(c == std::forward_list<int>(std::begin(a), std::end(a)));
   }
 
   return 0;