Skip to content

Commit f0c51be

Browse files
committed
Address review comment: Rename the variable
1 parent 3f3c04a commit f0c51be

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

compiler-rt/lib/scudo/standalone/primary32.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ template <typename Config> class SizeClassAllocator32 {
387387

388388
struct ReleaseToOsInfo {
389389
uptr BytesInFreeListAtLastCheckpoint;
390-
uptr NumReleaseAttempted;
390+
uptr NumReleasesAttempted;
391391
uptr LastReleasedBytes;
392392
u64 LastReleaseAtNs;
393393
};
@@ -882,11 +882,11 @@ template <typename Config> class SizeClassAllocator32 {
882882
const uptr AvailableChunks = Sci->AllocatedUser / BlockSize;
883883
Str->append(
884884
" %02zu (%6zu): mapped: %6zuK popped: %7zu pushed: %7zu "
885-
"inuse: %6zu avail: %6zu release count: %6zu last released: %6zuK "
885+
"inuse: %6zu avail: %6zu release attempted: %6zu last released: %6zuK "
886886
"latest pushed bytes: %6zuK\n",
887887
ClassId, getSizeByClassId(ClassId), Sci->AllocatedUser >> 10,
888888
Sci->FreeListInfo.PoppedBlocks, Sci->FreeListInfo.PushedBlocks, InUse,
889-
AvailableChunks, Sci->ReleaseInfo.NumReleaseAttempted,
889+
AvailableChunks, Sci->ReleaseInfo.NumReleasesAttempted,
890890
Sci->ReleaseInfo.LastReleasedBytes >> 10, PushedBytesDelta >> 10);
891891
}
892892

@@ -974,7 +974,7 @@ template <typename Config> class SizeClassAllocator32 {
974974

975975
// The following steps contribute to the majority time spent in page
976976
// releasing thus we increment the counter here.
977-
++Sci->ReleaseInfo.NumReleaseAttempted;
977+
++Sci->ReleaseInfo.NumReleasesAttempted;
978978

979979
// ==================================================================== //
980980
// 2. Mark the free blocks and we can tell which pages are in-use by

compiler-rt/lib/scudo/standalone/primary64.h

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1141,18 +1141,18 @@ template <typename Config> class SizeClassAllocator64 {
11411141
BytesInFreeList - Region->ReleaseInfo.BytesInFreeListAtLastCheckpoint;
11421142
}
11431143
const uptr TotalChunks = Region->MemMapInfo.AllocatedUser / BlockSize;
1144-
Str->append("%s %02zu (%6zu): mapped: %6zuK popped: %7zu pushed: %7zu "
1145-
"inuse: %6zu total: %6zu releases: %6zu last "
1146-
"release count: %6zuK latest pushed bytes: %6zuK region: 0x%zx "
1147-
"(0x%zx)\n",
1148-
Region->Exhausted ? "E" : " ", ClassId,
1149-
getSizeByClassId(ClassId), Region->MemMapInfo.MappedUser >> 10,
1150-
Region->FreeListInfo.PoppedBlocks,
1151-
Region->FreeListInfo.PushedBlocks, InUseBlocks, TotalChunks,
1152-
Region->ReleaseInfo.NumReleaseAttempted,
1153-
Region->ReleaseInfo.LastReleasedBytes >> 10,
1154-
RegionPushedBytesDelta >> 10, Region->RegionBeg,
1155-
getRegionBaseByClassId(ClassId));
1144+
Str->append(
1145+
"%s %02zu (%6zu): mapped: %6zuK popped: %7zu pushed: %7zu "
1146+
"inuse: %6zu total: %6zu releases: %6zu last "
1147+
"release attempted: %6zuK latest pushed bytes: %6zuK region: 0x%zx "
1148+
"(0x%zx)\n",
1149+
Region->Exhausted ? "E" : " ", ClassId, getSizeByClassId(ClassId),
1150+
Region->MemMapInfo.MappedUser >> 10, Region->FreeListInfo.PoppedBlocks,
1151+
Region->FreeListInfo.PushedBlocks, InUseBlocks, TotalChunks,
1152+
Region->ReleaseInfo.NumReleaseAttempted,
1153+
Region->ReleaseInfo.LastReleasedBytes >> 10,
1154+
RegionPushedBytesDelta >> 10, Region->RegionBeg,
1155+
getRegionBaseByClassId(ClassId));
11561156
}
11571157

11581158
void getRegionFragmentationInfo(RegionInfo *Region, uptr ClassId,

0 commit comments

Comments
 (0)