[Review] Test that we fail when the feature is disabled

Author: jmmartinez

clang/test/SemaOpenCL/amd-media-ops.cl

@@ -1,6 +1,10 @@
 // RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -cl-ext=-all,+cl_amd_media_ops,+cl_amd_media_ops2 -verify -pedantic -Wconversion -Werror -fsyntax-only -cl-std=CL -finclude-default-header
 // RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -cl-ext=-all,+cl_amd_media_ops,+cl_amd_media_ops2 -verify -pedantic -Wconversion -Werror -fsyntax-only -cl-std=CL -finclude-default-header -fdeclare-opencl-builtins
 // expected-no-diagnostics
+// RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -cl-ext=-all,+cl_amd_media_ops2 -verify=ops  -pedantic -Wconversion -Werror -fsyntax-only -cl-std=CL -finclude-default-header
+// RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -cl-ext=-all,+cl_amd_media_ops  -verify=ops2 -pedantic -Wconversion -Werror -fsyntax-only -cl-std=CL -finclude-default-header
+// RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -cl-ext=-all,+cl_amd_media_ops2 -verify=ops  -pedantic -Wconversion -Werror -fsyntax-only -cl-std=CL -finclude-default-header -fdeclare-opencl-builtins
+// RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -cl-ext=-all,+cl_amd_media_ops  -verify=ops2 -pedantic -Wconversion -Werror -fsyntax-only -cl-std=CL -finclude-default-header -fdeclare-opencl-builtins
 
 #define TEST_1ARG_BUILTIN_WITH_TYPE(builtin, ret, type) \
     ret test_ ## builtin ## _ ## ret ## _## type (type a) { \
@@ -54,45 +58,46 @@
     TEST_3ARG_BUILTIN_WITH_TYPES(builtin, ret ## 8, type_a ## 8, type_b ## 8, type_c ## 8) \
     TEST_3ARG_BUILTIN_WITH_TYPES(builtin, ret ## 16, type_a ## 16, type_b ## 16, type_c ## 16)
 
-TEST_3ARG_BUILTIN(amd_bitalign, uint, uint)
-TEST_3ARG_BUILTIN(amd_bytealign, uint, uint)
-TEST_3ARG_BUILTIN(amd_lerp, uint, uint)
+TEST_3ARG_BUILTIN(amd_bitalign, uint, uint) // ops-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_bytealign, uint, uint) // ops-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_lerp, uint, uint) // ops-error 6 {{use of undeclared identifier}}
 
 uint test_amd_pack(float4 a) {
-    return amd_pack(a);
+    return amd_pack(a); // ops-error{{use of undeclared identifier}}
 }
 
 uint test_amd_sad4(uint4 a, uint4 b, uint c) {
-    return amd_sad4(a, b, c);
+    return amd_sad4(a, b, c); // ops-error{{use of undeclared identifier}}
 }
 
-TEST_3ARG_BUILTIN(amd_sadhi, uint, uint)
-TEST_3ARG_BUILTIN(amd_sad, uint, uint)
+TEST_3ARG_BUILTIN(amd_sadhi, uint, uint)// ops-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_sad, uint, uint) // ops-error 6 {{use of undeclared identifier}}
 
-TEST_1ARG_BUILTIN(amd_unpack0, float, uint)
-TEST_1ARG_BUILTIN(amd_unpack1, float, uint)
-TEST_1ARG_BUILTIN(amd_unpack2, float, uint)
-TEST_1ARG_BUILTIN(amd_unpack3, float, uint)
 
-TEST_3ARG_WITH_TYPES_BUILTIN(amd_bfe, int, int, uint, uint)
-TEST_3ARG_BUILTIN(amd_bfe, uint, uint)
-TEST_2ARG_BUILTIN(amd_bfm, uint, uint)
+TEST_1ARG_BUILTIN(amd_unpack0, float, uint) // ops-error 6 {{use of undeclared identifier}}
+TEST_1ARG_BUILTIN(amd_unpack1, float, uint) // ops-error 6 {{use of undeclared identifier}}
+TEST_1ARG_BUILTIN(amd_unpack2, float, uint) // ops-error 6 {{use of undeclared identifier}}
+TEST_1ARG_BUILTIN(amd_unpack3, float, uint) // ops-error 6 {{use of undeclared identifier}}
 
-TEST_3ARG_BUILTIN(amd_max3, float, float)
-TEST_3ARG_BUILTIN(amd_max3, int, int)
-TEST_3ARG_BUILTIN(amd_max3, uint, uint)
+TEST_3ARG_WITH_TYPES_BUILTIN(amd_bfe, int, int, uint, uint) // ops2-error 6 {{use of undeclared identifier}} #amd_bfe0
+TEST_3ARG_BUILTIN(amd_bfe, uint, uint) // ops2-error 6 {{use of undeclared identifier}} #amd_bfe1
+TEST_2ARG_BUILTIN(amd_bfm, uint, uint) // ops2-error 6 {{use of undeclared identifier}}
 
-TEST_3ARG_BUILTIN(amd_median3, float, float)
-TEST_3ARG_BUILTIN(amd_median3, int, int)
-TEST_3ARG_BUILTIN(amd_median3, uint, uint)
+TEST_3ARG_BUILTIN(amd_max3, float, float) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_max3, int, int) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_max3, uint, uint) // ops2-error 6 {{use of undeclared identifier}}
 
-TEST_3ARG_BUILTIN(amd_min3, float, float)
-TEST_3ARG_BUILTIN(amd_min3, int, int)
-TEST_3ARG_BUILTIN(amd_min3, uint, uint)
+TEST_3ARG_BUILTIN(amd_median3, float, float) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_median3, int, int) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_median3, uint, uint) // ops2-error 6 {{use of undeclared identifier}}
 
-TEST_3ARG_WITH_TYPES_BUILTIN(amd_mqsad, ulong, ulong, uint, ulong)
-TEST_3ARG_WITH_TYPES_BUILTIN(amd_qsad, ulong, ulong, uint, ulong)
+TEST_3ARG_BUILTIN(amd_min3, float, float) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_min3, int, int) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_min3, uint, uint) // ops2-error 6 {{use of undeclared identifier}}
 
-TEST_3ARG_BUILTIN(amd_msad, uint, uint)
-TEST_3ARG_BUILTIN(amd_sadd, uint, uint)
-TEST_3ARG_BUILTIN(amd_sadw, uint, uint)
+TEST_3ARG_WITH_TYPES_BUILTIN(amd_mqsad, ulong, ulong, uint, ulong) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_WITH_TYPES_BUILTIN(amd_qsad, ulong, ulong, uint, ulong) // ops2-error 6 {{use of undeclared identifier}}
+
+TEST_3ARG_BUILTIN(amd_msad, uint, uint) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_sadd, uint, uint) // ops2-error 6 {{use of undeclared identifier}}
+TEST_3ARG_BUILTIN(amd_sadw, uint, uint) // ops2-error 6 {{use of undeclared identifier}}