resolve comments

Author: mingmingl-llvm

llvm/test/ThinLTO/X86/devirt_prevailing.ll

@@ -1,7 +1,7 @@
 ; RUN: rm -rf %t && mkdir %t && cd %t
 
 ; Tests that devirtualization is suppressed on a class when the LTO unit doesn't
-; have the prevailing definition of the class.
+; have the prevailing definition of the base class.
 
 ; Generate unsplit module with summary for ThinLTO index-based WPD.
 ; RUN: opt -thinlto-bc -o summary.o %s
@@ -16,10 +16,7 @@
 ; RUN:   --whole-program-visibility-enabled-in-lto=true \
 ; RUN:   --validate-all-vtables-have-type-infos=true \
 ; RUN:   --all-vtables-have-type-infos=true \
-; RUN:   -r=summary.o,__cxa_pure_virtual, \
-; RUN:   -r=summary.o,_ZN8DerivedNC2Ev,x \
 ; RUN:   -r=summary.o,_ZN4Base8dispatchEv,px \
-; RUN:   -r=summary.o,_ZN7DerivedC2Ev, \
 ; RUN:   -r=summary.o,_ZN8DerivedN5printEv,px \
 ; RUN:   -r=summary.o,_ZTV8DerivedN,p \
 ; RUN:   -r=summary.o,_ZTI8DerivedN,p \
@@ -38,10 +35,7 @@
 ; RUN:   --whole-program-visibility-enabled-in-lto=true \
 ; RUN:   --validate-all-vtables-have-type-infos=true \
 ; RUN:   --all-vtables-have-type-infos=true \
-; RUN:   -r=summary.o,__cxa_pure_virtual, \
-; RUN:   -r=summary.o,_ZN8DerivedNC2Ev,x \
 ; RUN:   -r=summary.o,_ZN4Base8dispatchEv,px \
-; RUN:   -r=summary.o,_ZN7DerivedC2Ev, \
 ; RUN:   -r=summary.o,_ZN8DerivedN5printEv,px \
 ; RUN:   -r=summary.o,_ZTV8DerivedN,p \
 ; RUN:   -r=summary.o,_ZTI8DerivedN,p \
@@ -58,10 +52,7 @@
 ; RUN:   --whole-program-visibility-enabled-in-lto=true \
 ; RUN:   --validate-all-vtables-have-type-infos=true \
 ; RUN:   --all-vtables-have-type-infos=true \
-; RUN:   -r=hybrid.o,__cxa_pure_virtual, \
-; RUN:   -r=hybrid.o,_ZN8DerivedNC2Ev,x \
 ; RUN:   -r=hybrid.o,_ZN4Base8dispatchEv,px \
-; RUN:   -r=hybrid.o,_ZN7DerivedC2Ev, \
 ; RUN:   -r=hybrid.o,_ZN8DerivedN5printEv,px \
 ; RUN:   -r=hybrid.o,_ZTV8DerivedN, \
 ; RUN:   -r=hybrid.o,_ZTI8DerivedN, \
@@ -79,10 +70,7 @@
 ; RUN:   --whole-program-visibility-enabled-in-lto=true \
 ; RUN:   --validate-all-vtables-have-type-infos=true \
 ; RUN:   --all-vtables-have-type-infos=true \
-; RUN:   -r=hybrid.o,__cxa_pure_virtual, \
-; RUN:   -r=hybrid.o,_ZN8DerivedNC2Ev,x \
 ; RUN:   -r=hybrid.o,_ZN4Base8dispatchEv,px \
-; RUN:   -r=hybrid.o,_ZN7DerivedC2Ev, \
 ; RUN:   -r=hybrid.o,_ZN8DerivedN5printEv,px \
 ; RUN:   -r=hybrid.o,_ZTV8DerivedN, \
 ; RUN:   -r=hybrid.o,_ZTI8DerivedN, \
@@ -103,10 +91,7 @@
 ; RUN:   --whole-program-visibility-enabled-in-lto=true \
 ; RUN:   --validate-all-vtables-have-type-infos=true \
 ; RUN:   --all-vtables-have-type-infos=true \
-; RUN:   -r=regular.o,__cxa_pure_virtual, \
-; RUN:   -r=regular.o,_ZN8DerivedNC2Ev,x \
 ; RUN:   -r=regular.o,_ZN4Base8dispatchEv,px \
-; RUN:   -r=regular.o,_ZN7DerivedC2Ev, \
 ; RUN:   -r=regular.o,_ZN8DerivedN5printEv,px \
 ; RUN:   -r=regular.o,_ZTS8DerivedN,p \
 ; RUN:   -r=regular.o,_ZTI7Derived,p \
@@ -120,10 +105,7 @@
 ; RUN:   --whole-program-visibility-enabled-in-lto=true \
 ; RUN:   --validate-all-vtables-have-type-infos=true \
 ; RUN:   --all-vtables-have-type-infos=true \
-; RUN:   -r=regular.o,__cxa_pure_virtual, \
-; RUN:   -r=regular.o,_ZN8DerivedNC2Ev,x \
 ; RUN:   -r=regular.o,_ZN4Base8dispatchEv,px \
-; RUN:   -r=regular.o,_ZN7DerivedC2Ev, \
 ; RUN:   -r=regular.o,_ZN8DerivedN5printEv,px \
 ; RUN:   -r=regular.o,_ZTS8DerivedN,p \
 ; RUN:   -r=regular.o,_ZTI7Derived, \
@@ -136,12 +118,14 @@
 target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
 
-@_ZTV8DerivedN = linkonce_odr hidden constant { [3 x ptr] } { [3 x ptr] [ptr null, ptr @_ZTI8DerivedN, ptr @_ZN8DerivedN5printEv] }, !type !0, !type !1, !type !2, !type !3, !vcall_visibility !6
+@_ZTV8DerivedN = linkonce_odr hidden constant { [3 x ptr] } { [3 x ptr] [ptr null, ptr @_ZTI8DerivedN, ptr @_ZN8DerivedN5printEv] }, !type !0, !type !1, !type !2, !type !3, !vcall_visibility !4
 @_ZTI8DerivedN = linkonce_odr hidden constant { ptr, ptr, ptr } { ptr null, ptr @_ZTS8DerivedN, ptr @_ZTI7Derived }
 @_ZTS8DerivedN = linkonce_odr hidden constant [10 x i8] c"8DerivedN\00", align 1
 @_ZTI7Derived = external constant ptr
 
-@llvm.used = appending global [1 x ptr] [ptr @_ZN8DerivedNC2Ev], section "llvm.metadata"
+; Whole program devirtualization will ignore summaries that are not live.
+; Mark '_ZTV8DerivedN' as used so it remains live.
+@llvm.used = appending global [1 x ptr] [ptr @_ZTV8DerivedN], section "llvm.metadata"
 
 define hidden void @_ZN4Base8dispatchEv(ptr %this) {
 entry:
@@ -157,32 +141,18 @@ entry:
   ret void
 }
 
-define linkonce_odr hidden void @_ZN8DerivedNC2Ev(ptr %this) #0 {
-entry:
-  %this.addr = alloca ptr
-  store ptr %this, ptr %this.addr
-  %this1 = load ptr, ptr %this.addr
-  call void @_ZN7DerivedC2Ev(ptr %this1)
-  store ptr getelementptr inbounds inrange(-16, 8) ({ [3 x ptr] }, ptr @_ZTV8DerivedN, i32 0, i32 0, i32 2), ptr %this1
-  ret void
-}
-
 define linkonce_odr hidden void @_ZN8DerivedN5printEv(ptr %this) #0 {
 entry:
   ret void
 }
 
 attributes #0 = { noinline optnone }
 
-declare void @__cxa_pure_virtual()
 declare i1 @llvm.type.test(ptr, metadata)
 declare void @llvm.assume(i1)
-declare void @_ZN7DerivedC2Ev(ptr)
 
 !0 = !{i64 16, !"_ZTS7Derived"}
 !1 = !{i64 16, !"_ZTSM7DerivedFvvE.virtual"}
 !2 = !{i64 16, !"_ZTS8DerivedN"}
 !3 = !{i64 16, !"_ZTSM8DerivedNFvvE.virtual"}
-;!4 = !{i64 16, !"_ZTS8DerivedN"}
-;!5 = !{i64 16, !"_ZTSM8DerivedNFvvE.virtual"}
-!6 = !{i64 0}
+!4 = !{i64 0}