Addressed feedback

Author: adam-yang

llvm/lib/Target/DirectX/DXILOpLowering.cpp

@@ -116,35 +116,35 @@ class OpLowerer {
   };
 
   [[nodiscard]] bool replaceFunctionWithOp(Function &F, dxil::OpCode DXILOp,
-                                           ArrayRef<ArgSelect> Args) {
+                                           ArrayRef<ArgSelect> ArgSelects) {
     bool IsVectorArgExpansion = isVectorArgExpansion(F);
     return replaceFunction(F, [&](CallInst *CI) -> Error {
       OpBuilder.getIRB().SetInsertPoint(CI);
-      SmallVector<Value *> NewArgs;
-      if (Args.size()) {
-        for (const ArgSelect &A : Args) {
+      SmallVector<Value *> Args;
+      if (ArgSelects.size()) {
+        for (const ArgSelect &A : ArgSelects) {
           switch (A.Type) {
           case ArgSelect::Type::Index:
-            NewArgs.push_back(CI->getArgOperand(A.Value));
+            Args.push_back(CI->getArgOperand(A.Value));
             break;
           case ArgSelect::Type::I8:
-            NewArgs.push_back(OpBuilder.getIRB().getInt8((uint8_t)A.Value));
+            Args.push_back(OpBuilder.getIRB().getInt8((uint8_t)A.Value));
             break;
           case ArgSelect::Type::I32:
-            NewArgs.push_back(OpBuilder.getIRB().getInt32(A.Value));
+            Args.push_back(OpBuilder.getIRB().getInt32(A.Value));
             break;
           default:
             llvm_unreachable("Invalid type of intrinsic arg select.");
           }
         }
       } else if (IsVectorArgExpansion) {
-        NewArgs = argVectorFlatten(CI, OpBuilder.getIRB());
+        Args = argVectorFlatten(CI, OpBuilder.getIRB());
       } else {
-        NewArgs.append(CI->arg_begin(), CI->arg_end());
+        Args.append(CI->arg_begin(), CI->arg_end());
       }
 
-      Expected<CallInst *> OpCall = OpBuilder.tryCreateOp(
-          DXILOp, NewArgs, CI->getName(), F.getReturnType());
+      Expected<CallInst *> OpCall =
+          OpBuilder.tryCreateOp(DXILOp, Args, CI->getName(), F.getReturnType());
       if (Error E = OpCall.takeError())
         return E;
 

llvm/test/CodeGen/DirectX/group_memory_barrier_with_group_sync.ll

@@ -1,4 +1,4 @@
-; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library < %s | FileCheck %s --check-prefix=CHECK
+; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library < %s | FileCheck %s
 
 define void @test_group_memory_barrier_with_group_sync() {
 entry:

llvm/utils/TableGen/DXILEmitter.cpp

@@ -40,7 +40,7 @@ struct DXILArgSelect {
     I8,
   };
   Type Type = Type::Index;
-  int Value = 0;
+  int Value = -1;
 };
 struct DXILIntrinsicSelect {
   StringRef Intrinsic;