#95641 pointless string copy

Author: sommersun

llvm/include/llvm/TableGen/Record.h

@@ -1966,9 +1966,7 @@ class RecordKeeper {
     return It == ExtraGlobals.end() ? nullptr : It->second;
   }
 
-  void saveInputFilename(std::string Filename) {
-    InputFilename = Filename;
-  }
+  void saveInputFilename(std::string &&Filename) { InputFilename = Filename; }
 
   void addClass(std::unique_ptr<Record> R) {
     bool Ins =

llvm/lib/TableGen/Main.cpp

@@ -113,7 +113,7 @@ int llvm::TableGenMain(const char *argv0,
     return reportError(argv0, "Could not open input file '" + InputFilename +
                                   "': " + EC.message() + "\n");
 
-  Records.saveInputFilename(InputFilename);
+  Records.saveInputFilename(std::move(InputFilename));
 
   // Tell SrcMgr about this buffer, which is what TGParser will pick up.
   SrcMgr.AddNewSourceBuffer(std::move(*FileOrErr), SMLoc());