Address review comments.

Author: mshahneo

mlir/include/mlir/Dialect/XeGPU/uArch/IntelGpuXe2.h

@@ -37,7 +37,6 @@ struct XeCoreInfo {
   uint32_t num_vector_units;
   uint32_t num_matrix_units;
 
-  // Constructor
   XeCoreInfo(uint32_t num_threads, const SharedMemory &shared_memory,
              uint32_t num_vector_units, uint32_t num_matrix_units)
       : num_threads(num_threads), shared_memory(shared_memory),
@@ -60,10 +59,7 @@ struct Xe2Plus : public uArch {
 // struct to represent DPAS instruction
 struct DPASInstruction : public Instruction, public MMAInstructionInterface {
   DPASInstruction()
-      : Instruction(InstructionKind::DPAS, // name
-                    "Dot Product Accumulate",
-                    InstructionScope::Subgroup) // description
-  {}
+      : Instruction(InstructionKind::DPAS, InstructionScope::Subgroup) {}
 
   // Override all virtuals from MatrixOpInterface
   virtual llvm::SmallVector<std::pair<uint32_t, uint32_t>, 16>

mlir/include/mlir/Dialect/XeGPU/uArch/uArchBase.h

@@ -69,13 +69,12 @@ std::optional<InstructionKind> parseInstructionKind(llvm::StringRef str) {
 // struct and add more fields as needed
 struct Instruction {
   // @TODO: Add more fields as needed
-  Instruction(InstructionKind kind, std::string desc, InstructionScope scope)
-      : instKind(kind), description(std::move(desc)), scope(scope) {}
+  Instruction(InstructionKind kind, InstructionScope scope)
+      : instKind(kind), scope(scope) {}
 
   virtual ~Instruction() = default;
   // Get methods
   InstructionKind getInstructionKind() { return instKind; }
-  std::string getDescription() { return description; }
   InstructionScope getScope() { return scope; }
 
 protected:
@@ -143,7 +142,7 @@ struct CacheInfo {
 // - the name of the uArch,
 // - the description of the uArch,
 // - uArch hierarchy
-// - Rgister File information
+// - Register File information
 // - Cache information
 // - the set of instructions supported by the uArch,
 struct uArch {