address pr comments

Author: farzonl

llvm/lib/Target/DirectX/DXILOpLowering.cpp

@@ -770,12 +770,17 @@ class OpLowerer {
         continue;
       Intrinsic::ID ID = F.getIntrinsicID();
       switch (ID) {
+      // NOTE: Skip dx_resource_casthandle here. They are
+      // resolved after this loop in cleanupHandleCasts.
       case Intrinsic::dx_resource_casthandle:
+      // NOTE: llvm.dbg.value is supported as is in DXIL.
+      case Intrinsic::dbg_value:
       case Intrinsic::not_intrinsic:
         continue;
       default: {
         DiagnosticInfoUnsupported Diag(F, "Unknown intrinsic?");
         M.getContext().diagnose(Diag);
+        HasErrors |= true;
         break;
       }
 #define DXIL_OP_INTRINSIC(OpCode, Intrin, ...)                                 \

llvm/test/CodeGen/DirectX/unknown_intrinsic.ll

@@ -1,4 +1,4 @@
-; RUN: not opt -S -scalarizer -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s 2>&1 | FileCheck %s
+; RUN: not opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s 2>&1 | FileCheck %s
 
 ; CHECK: error: <unknown>:0:0: in function llvm.vector.reduce.and.v4i32 i32 (<4 x i32>): Unknown intrinsic?
 define i32 @fn_and(<4 x i32> %0) local_unnamed_addr #0 {