Greg comment feedback

Author: Jlalond

lldb/bindings/interface/SBProgressDocstrings.i

@@ -25,15 +25,33 @@ throttling rate than deterministic ones.
 
 Below are examples in Python for deterministic and non-deterministic progresses.
 
-    deterministic_progress = lldb.SBProgress('Deterministic Progress', 'Detail', 3, lldb.SBDebugger)
-    for i in range(3):
-        deterministic_progress.Increment(1, f'Update {i}')
+    deterministic_progress1 = lldb.SBProgress('Deterministic Progress', 'Detail', 3, lldb.SBDebugger) 
+    for i in range(3): 
+        deterministic_progress1.Increment(1, f'Update {i}') 
+        
+    # The call to Finalize() is a no-op as we already incremented the right amount of 
+    # times and caused the end event to be sent. 
+    deterministic_progress1.Finalize() 
+    deterministic_progress2 = lldb.SBProgress('Deterministic Progress', 'Detail', 10, lldb.SBDebugger) 
+    for i in range(3): 
+        deterministic_progress2.Increment(1, f'Update {i}') 
+        
+    # Cause the progress end event to be sent even if we didn't increment the right 
+    # number of times. Real world examples would be in a try-finally block to ensure
+    # progress clean-up.
+
+    deterministic_progress2.Finalize() 
+If you don't call Finalize() when the progress is not done, the progress object will eventually get
+garbage collected by the Python runtime, the end event will eventually get sent, but it is best not to 
+rely on the garbage collection when using lldb.SBProgress.
+
+Non-deterministic progresses behave the same, but omit the total in the constructor.
 
     non_deterministic_progress = lldb.SBProgress('Non deterministic progress, 'Detail', lldb.SBDebugger)
     for i in range(10):
         non_deterministic_progress.Increment(1)
-
-    # Explicitly send a progressEnd from Python.
+    # Explicitly send a progressEnd, otherwise this will be sent
+    # when the python runtime cleans up this object.
     non_deterministic_progress.Finalize()
 ") lldb::SBProgress;    
 

lldb/test/API/tools/lldb-dap/progress/TestDAP_Progress.py

@@ -19,7 +19,7 @@ def verify_progress_events(
         expected_not_in_message=None,
         only_verify_first_update=False,
     ):
-        self.dap_server.wait_for_event("progressEnd", 5)
+        self.dap_server.wait_for_event("progressEnd", 15)
         self.assertTrue(len(self.dap_server.progress_events) > 0)
         start_found = False
         update_found = False