remove HasLocalSummary var as the Summary doesn't get built in this patch

Author: hassnaaHamdi

llvm/include/llvm/Transforms/IPO/WholeProgramDevirt.h

@@ -226,10 +226,6 @@ struct WholeProgramDevirtPass : public PassInfoMixin<WholeProgramDevirtPass> {
   ModuleSummaryIndex *ExportSummary;
   const ModuleSummaryIndex *ImportSummary;
   bool UseCommandLine = false;
-  // True if ExportSummary was built locally from the module rather than
-  // provided externally to the pass (e.g., during LTO). Default value is false
-  // unless explicitly set when the Summary is explicitly built.
-  bool HasLocalSummary = false;
   WholeProgramDevirtPass()
       : ExportSummary(nullptr), ImportSummary(nullptr), UseCommandLine(true) {}
   WholeProgramDevirtPass(ModuleSummaryIndex *ExportSummary,

llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp

@@ -605,9 +605,6 @@ struct DevirtModule {
 
   ModuleSummaryIndex *const ExportSummary;
   const ModuleSummaryIndex *const ImportSummary;
-  // True if ExportSummary was built locally from the module.
-  // Default is false unless explicitly set.
-  const bool HasLocalSummary;
 
   IntegerType *const Int8Ty;
   PointerType *const Int8PtrTy;
@@ -645,12 +642,10 @@ struct DevirtModule {
 
   DevirtModule(Module &M, ModuleAnalysisManager &MAM,
                ModuleSummaryIndex *ExportSummary,
-               const ModuleSummaryIndex *ImportSummary,
-               bool HasLocalSummary = false)
+               const ModuleSummaryIndex *ImportSummary)
       : M(M), MAM(MAM),
         FAM(MAM.getResult<FunctionAnalysisManagerModuleProxy>(M).getManager()),
         ExportSummary(ExportSummary), ImportSummary(ImportSummary),
-        HasLocalSummary(HasLocalSummary),
         Int8Ty(Type::getInt8Ty(M.getContext())),
         Int8PtrTy(PointerType::getUnqual(M.getContext())),
         Int32Ty(Type::getInt32Ty(M.getContext())),
@@ -821,8 +816,7 @@ PreservedAnalyses WholeProgramDevirtPass::run(Module &M,
       return PreservedAnalyses::all();
     return PreservedAnalyses::none();
   }
-  if (!DevirtModule(M, MAM, ExportSummary, ImportSummary, HasLocalSummary)
-           .run())
+  if (!DevirtModule(M, MAM, ExportSummary, ImportSummary).run())
     return PreservedAnalyses::all();
   return PreservedAnalyses::none();
 }
@@ -1363,10 +1357,10 @@ bool DevirtModule::trySingleImplDevirt(
   if (!IsExported)
     return false;
 
-  // If the only implementation has local linkage, we must promote
-  // to external to make it visible to thin LTO objects.
-  // This change should be safe only in LTO mode.
-  if (!HasLocalSummary && TheFn->hasLocalLinkage()) {
+  // If the only implementation has local linkage, we must promote to external
+  // to make it visible to thin LTO objects. We can only get here during the
+  // ThinLTO export phase.
+  if (TheFn->hasLocalLinkage()) {
     std::string NewName = (TheFn->getName() + ".llvm.merged").str();
 
     // Since we are renaming the function, any comdats with the same name must