address review comments + snake_case python func return type

Author: tkarna

mlir/include/mlir/Dialect/XeGPU/TransformOps/XeGPUTransformOps.td

@@ -167,8 +167,8 @@ def SetGPULaunchThreadsOp
       TransformOpInterface
     ]> {
 
-  let summary = "Set number of threads for a given gpu.launch operation"; let
-  description = [{
+  let summary = "Set number of threads for a given gpu.launch operation";
+  let description = [{
     Overrides the x,y,z threads operands of a given `gpu.launch` operation in-place.
   }];
 

mlir/python/mlir/dialects/transform/xegpu.py

@@ -166,5 +166,5 @@ def set_gpu_launch_threads(
     *,
     loc=None,
     ip=None,
-):
+) -> SetGPULaunchThreadsOp:
     return SetGPULaunchThreadsOp(launch_op, threads, loc=loc, ip=ip)

mlir/test/Dialect/XeGPU/transform-ops-invalid.mlir

@@ -112,7 +112,7 @@ func.func @set_gpu_launch_threads_bad_threads(%arg0: memref<4096x4096xf16>) {
   %c16 = arith.constant 16 : index
   gpu.launch blocks(%arg3, %arg4, %arg5) in (%arg9 = %c16, %arg10 = %c16, %arg11 = %c1) threads(%arg6, %arg7, %arg8) in (%arg12 = %c1, %arg13 = %c1, %arg14 = %c1) {
     gpu.terminator
-  } {SCFToGPU_visited}
+  }
   return
 }
 

mlir/test/Dialect/XeGPU/transform-ops.mlir

@@ -269,7 +269,7 @@ func.func @set_gpu_launch_threads(%arg0: memref<4096x4096xf16>) {
   // CHECK-SAME: threads(%{{.*}}, %{{.*}}, %{{.*}}) in (%{{.*}} = %[[C8]], %{{.*}} = %[[C4]], %{{.*}} = %[[C1_0]])
   gpu.launch blocks(%arg3, %arg4, %arg5) in (%arg9 = %c16, %arg10 = %c16, %arg11 = %c1) threads(%arg6, %arg7, %arg8) in (%arg12 = %c1, %arg13 = %c1, %arg14 = %c1) {
     gpu.terminator
-  } {SCFToGPU_visited}
+  }
   return
 }
 module attributes {transform.with_named_sequence} {
@@ -296,7 +296,7 @@ func.func @set_gpu_launch_threads_param(%arg0: memref<4096x4096xf16>) {
   // CHECK-SAME: threads(%{{.*}}, %{{.*}}, %{{.*}}) in (%{{.*}} = %[[C8]], %{{.*}} = %[[C4]], %{{.*}} = %[[C1_0]])
   gpu.launch blocks(%arg3, %arg4, %arg5) in (%arg9 = %c16, %arg10 = %c16, %arg11 = %c1) threads(%arg6, %arg7, %arg8) in (%arg12 = %c1, %arg13 = %c1, %arg14 = %c1) {
     gpu.terminator
-  } {SCFToGPU_visited}
+  }
   return
 }
 module attributes {transform.with_named_sequence} {